Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 434370

Summary:	Downloading zips and Uploading a file fails
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Node	Assignee:	Silenio Quarti <Silenio_Quarti>
Status:	RESOLVED FIXED	QA Contact:
Severity:	major
Priority:	P1	CC:	Carolyn_MacLeod, Mike_Wilson, Olivier_Thomann
Version:	5.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2014-05-07 15:49:41 EDT

1. Launch Orion node server
2. Drag & drop a file from your PC desktop into a folder in the orion navigator
3. The UI refreshes, but the file is never uploaded.

Import > File System fails in the same manner.

There's an error logged to the console:
> POST http://localhost:8081/edit/undefined 404 (Not Found)   fileCommands.js:138
> fileCommandUtils.uploadFile                                 fileCommands.js:138
>(anonymous function)                                       explorer-table.js:756
> settleDeferred
> ...

This is very bad because it prevents you from getting any content onto your 
server. Import+unzipping a zip file is not expected to work (see bug 407267), but basic file upload needs to work.

Comment 1 Mark Macdonald

2014-05-29 12:51:18 EDT

I thought this was a regression, but I guess it is not. Upload has never worked

Comment 2 Mark Macdonald

2014-05-29 13:00:31 EDT

Having said that, I'm surprised we still rely on a special server API for this functionality. I thought we would be using a pure HTML5+fileclient solution (except maybe when dealing with ZIP files)

Comment 3 Mark Macdonald

2014-05-29 13:42:37 EDT

And we're using a raw XHR from the UI to the server, so this will never work cross-origin (eg. try install your OrionHub fileClientPlugin on orion.eclipse.org, you cannot D&D into the remote filesystem, nor use Import. This seems wrong on several counts.

Comment 4 Mark Macdonald

2016-03-31 13:28:46 EDT

*** Bug 490815 has been marked as a duplicate of this bug. ***

Comment 5 Carolyn MacLeod

2016-03-31 14:16:57 EDT

So is Bug 483315 also a dup of this?

Comment 6 Silenio Quarti

2016-03-31 19:16:31 EDT

(In reply to Carolyn MacLeod from comment #5)
> So is Bug 483315 also a dup of this?

This one is for the node server.

Comment 7 Silenio Quarti

2016-03-31 19:20:01 EDT

Fixed zip downloading:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=3be43e2e1a5ff673c888318a422d937cb16594d7

Comment 8 Silenio Quarti

2016-04-01 16:07:15 EDT

I have implemented the most common cases (import file/zip, import url, export file/zip). SFtp will be done in another bug.