Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 434367

Summary: [esprima] Parsing should recover from missing ',' in argument listings for call expressions
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: mamacdon
Version: 6.0   
Target Milestone: 6.0 M2   
Hardware: All   
OS: All   
Whiteboard:

Description Michael Rennie CLA 2014-05-07 14:55:37 EDT
This would apply to anywhere you have a comma separated listing really - specifically call expressions (content assist) and function decls / expr
Comment 1 Michael Rennie CLA 2014-05-08 00:49:40 EDT
I opted to only recover from missing tokens in call expressions in this bug, so that I would not end up with a giant fix for all possible argument listings.

Pushed fix + tests + recovered occurrence tests to:

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=47977b2da941d947f287b6767be86ebd5bf233bd

I will open separate bugs for each different area of recovery around arguments as I determine if recovery makes sense.