Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 434337

Summary: org.eclipse.orion.server.tests/testData/importTest/あ.txt causes egit problems on a mac
Product: [ECD] Orion Reporter: Anton McConville <antonm>
Component: ClientAssignee: Anthony Hunter <ahunter.eclipse>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse, mamacdon.bugs, mamacdon
Version: unspecified   
Target Milestone: 6.0 RC3   
Hardware: PC   
OS: Mac OS X   
Whiteboard:

Description Anton McConville CLA 2014-05-07 10:38:24 EDT
This file ...

org.eclipse.orion.server.tests/testData/importTest/あ.txt

causes problems for egit on a mac - I guess because of the international character. I can't resolve the issue from my installation and I see this:

An internal error occurred during: "Computing Git status for repository org.eclipse.orion.server".
Malformed input or input contains unmappable chacraters: /Users/antonm/git/org.eclipse.orion.server/tests/org.eclipse.orion.server.tests/testData/importTest/あ.txt

with every operation - even when I save a file

Is there any chance this file could be generated - or somehow optionally included or something?
Comment 1 Anton McConville CLA 2014-06-17 14:37:59 EDT
This is still causing me problems. Please point me at the code, and I'll work to generate the file.
Comment 2 Anthony Hunter CLA 2014-06-17 14:54:02 EDT
Since the file was added to test a file name defect rather than a file contents defect, I have wiped out the unicode characters from the file with commit:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=212cc228331e24cc8db861680f99335ff04180b6

Give it another try.
Comment 3 Mark Macdonald CLA 2014-07-04 11:42:19 EDT
Anton is still experiencing this bug, so reopening. 

The problem seems to be "あ" in the filename, not the file contents.
Comment 4 Anthony Hunter CLA 2014-07-04 12:04:17 EDT
I will try the latest eGit at home on my Mac and see if I can duplicate the issue.
Comment 5 Mark Macdonald CLA 2014-07-04 12:08:40 EDT
I released a change that generates the test file on-the-fly instead of storing it in the repo. Hopefully this will prevent EGit from choking on the あ.txt file.
 http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=055bc4e
 http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=8f4d66c
 http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=89a44e1


Anthony: if you want to try to reproduce the issue, do a hard reset on your server repo to commit 5be1f06, and the problematic file should appear again.
Comment 6 Anton McConville CLA 2014-07-04 12:09:08 EDT
I appreciate all the work you've put in, but I have a workaround now, which is to avoid using egit, and to clone from the command line and import the projects from there.

It makes a huge difference not to see the error any more when working with eclipse.
Comment 7 Anthony Hunter CLA 2014-07-04 12:27:29 EDT
(In reply to Mark Macdonald from comment #5)
> Anthony: if you want to try to reproduce the issue, do a hard reset on your
> server repo to commit 5be1f06, and the problematic file should appear again.

No need to look further, problem solved.