| Summary: | Tycho build has 315 Junit test failures | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Anthony Hunter <ahunter.eclipse> |
| Component: | Server | Assignee: | Anthony Hunter <ahunter.eclipse> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 6.0 | ||
| Target Milestone: | 6.0 M2 | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Whiteboard: | |||
|
Description
Anthony Hunter
(In reply to Anthony Hunter from comment #0) > I thought I had everything right, but one of the last Tycho build tweaks I > did last night with Bug 430924 is causing the server JUnits to fail. > > Somehow the VM arguments are no longer being passed to the > tycho-surefire-plugin. Not sure how the tests worked before, but we were using the deprecated systemProperties configuration element in a non standard format to pass in the VM arguments to the tests: http://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html I have replaced with the argLine configuration element. Tests now are 100% successful again on my machine. Fixed with commit: http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=42f3c366ee252b9b311775d782f5ea42f27d4c69 (In reply to Anthony Hunter from comment #0) > I thought I had everything right, but one of the last Tycho build tweaks I > did last night with Bug 430924 is causing the server JUnits to fail. > > Somehow the VM arguments are no longer being passed to the > tycho-surefire-plugin. Not sure how the tests worked before, but we were using the deprecated systemProperties configuration element in a non standard format to pass in the VM arguments to the tests: http://maven.apache.org/surefire/maven-surefire-plugin/examples/system-properties.html I have replaced with the argLine configuration element. Tests now are 100% successful again on my machine. Fixed with commit: http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=42f3c366ee252b9b311775d782f5ea42f27d4c69 Additional commit where I forgot to use the ${http.port} property created by the reserve-network-port goal that finds unused ports on the server:
http://git.eclipse.org/c/orion/org.eclipse.orion.server.git/commit/?id=fc6d36eb7bc896b182629431acaec3525e29c04e
|