Bugzilla – Full Text Bug Listing
| Summary: | [CSS] toolbar is now grey on GTK | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Paul Webster <pwebster> | ||||
| Component: | UI | Assignee: | Platform UI Triaged <platform-ui-triaged> | ||||
| Status: | CLOSED DUPLICATE | QA Contact: | Daniel Rolka <daniel.rolka> | ||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | andrea.guarinoni, daniel_megert | ||||
| Version: | 4.4 | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | PC | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
(In reply to Paul Webster from comment #0) > Created attachment 242577 [details] > Package Explorer with grey toolbar > > The toolbar of the active part used to be white, as late as I20140427-2030. > > Now it's grey when the active tab is white, and doesn't look right. It works as desired, see the Bug 430872. Do you want to revert the white toolbar on GTK anyway? If so, we have to define the separate CSS property for it (now it uses the 'swt-unselected-tabs-color' one) Daniel Also the 'Dark' theme is still corrupted and cannot be patched in CSS, see https://bugs.eclipse.org/bugs/show_bug.cgi?id=433830 Would it be feasible to use the 'background-color' property for it (currently it seems to be unused in CTabFolder)? (In reply to Andrea Guarinoni from comment #2) > Also the 'Dark' theme is still corrupted and cannot be patched in CSS, see > https://bugs.eclipse.org/bugs/show_bug.cgi?id=433830 > > Would it be feasible to use the 'background-color' property for it > (currently it seems to be unused in CTabFolder)? The CTabFolder uses the 'background-color' property. You have to remove the 'swt-selected-tab-fill' and 'swt-unselected-tabs-color' properties from the CSS file in order to see the effect. However there are the issues during rendering the 'background-color' color that I believe we will be able to fix in the proper manner when the Bug 433276 is ready Daniel (In reply to Daniel Rolka from comment #3) > (In reply to Andrea Guarinoni from comment #2) > > Also the 'Dark' theme is still corrupted and cannot be patched in CSS, see > > https://bugs.eclipse.org/bugs/show_bug.cgi?id=433830 > > > > Would it be feasible to use the 'background-color' property for it > > (currently it seems to be unused in CTabFolder)? > > The CTabFolder uses the 'background-color' property. You have to remove the > 'swt-selected-tab-fill' and 'swt-unselected-tabs-color' properties from the > CSS file in order to see the effect. However there are the issues during > rendering the 'background-color' color that I believe we will be able to fix > in the proper manner when the Bug 433276 is ready > > Daniel I see, thanks Daniel, by removing the 'swt-selected-tab-fill' and 'swt-unselected-tabs-color' properties, the alue of the 'background-color' property is used to paint the background of the uselected tabs and of the ToolBar while the selected tab and the space below it that contains the ToolBar remain unstyled, I agree that there are painting issues that need to be checked. (In reply to Daniel Rolka from comment #1) > (In reply to Paul Webster from comment #0) > > Created attachment 242577 [details] > > Package Explorer with grey toolbar > > > > The toolbar of the active part used to be white, as late as I20140427-2030. > > > > Now it's grey when the active tab is white, and doesn't look right. > > It works as desired, see the Bug 430872. Do you want to revert the white > toolbar on GTK anyway? Yes, the toolbar color should stay the same as it was, certainly for Luna. PW (In reply to Paul Webster from comment #5) > (In reply to Daniel Rolka from comment #1) > > (In reply to Paul Webster from comment #0) > > > Created attachment 242577 [details] > > > Package Explorer with grey toolbar > > > > > > The toolbar of the active part used to be white, as late as I20140427-2030. > > > > > > Now it's grey when the active tab is white, and doesn't look right. > > > > It works as desired, see the Bug 430872. Do you want to revert the white > > toolbar on GTK anyway? > > Yes, the toolbar color should stay the same as it was, certainly for Luna. > > PW +1. *** This bug has been marked as a duplicate of bug 434134 *** |
Created attachment 242577 [details] Package Explorer with grey toolbar The toolbar of the active part used to be white, as late as I20140427-2030. Now it's grey when the active tab is white, and doesn't look right.