Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 433477

Summary:	[CSS] [Dark] Provide reasonable CDT defaults for syntax color in the dark theme
Product:	[Tools] CDT	Reporter:	Lars Vogel <Lars.Vogel>
Component:	cdt-editor	Assignee:	Doug Schaefer <cdtdoug>
Status:	RESOLVED FIXED	QA Contact:	Anton Leherbauer <aleherb+eclipse>
Severity:	normal
Priority:	P3	CC:	andrea.guarinoni, cdtdoug, Lars.Vogel, loskutov, marc.khouzam
Version:	8.4.0
Target Milestone:	8.4.0
Hardware:	PC
OS:	Linux
Whiteboard:
Bug Depends on:
Bug Blocks:	433475, 515393

Description Lars Vogel

2014-04-24 19:14:27 EDT

Similar to Bug 433475 we should add reasonable defaults for syntax highlighting for CDT.

Doug, can you upload a Gerrit reivew for CDT? See Bug 433475 for an example.

The following values are based on the https://github.com/guari/eclipse-ui-theme from Andrea who donate the theme to Eclipse, maybe you can use them?

/instance/org.eclipse.cdt.ui/asm_directive=221,40,103
/instance/org.eclipse.cdt.ui/asm_label=217,232,247
/instance/org.eclipse.cdt.ui/c_braces=249,250,244
/instance/org.eclipse.cdt.ui/c_comment_task_tag=154,140,124
/instance/org.eclipse.cdt.ui/c_default=217,232,247
/instance/org.eclipse.cdt.ui/c_keyword=221,40,103
/instance/org.eclipse.cdt.ui/c_multi_line_comment=98,98,98
/instance/org.eclipse.cdt.ui/c_numbers=104,151,187
/instance/org.eclipse.cdt.ui/c_operators=230,230,250
/instance/org.eclipse.cdt.ui/c_single_line_comment=98,98,98
/instance/org.eclipse.cdt.ui/c_string=23,198,163
/instance/org.eclipse.cdt.ui/c_type=221,40,103
/instance/org.eclipse.cdt.ui/org.eclipse.cdt.internal.ui.text.doctools.multi=98,98,98
/instance/org.eclipse.cdt.ui/org.eclipse.cdt.internal.ui.text.doctools.recognizedTag=30,120,155
/instance/org.eclipse.cdt.ui/org.eclipse.cdt.internal.ui.text.doctools.single=98,98,98
/instance/org.eclipse.cdt.ui/pp_default=217,232,247
/instance/org.eclipse.cdt.ui/pp_directive=221,40,103
/instance/org.eclipse.cdt.ui/pp_header=23,198,163
/instance/org.eclipse.cdt.ui/semanticHighlighting.class.color=18,144,195
/instance/org.eclipse.cdt.ui/semanticHighlighting.class.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.class.bold=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.enum.color=204,129,186
/instance/org.eclipse.cdt.ui/semanticHighlighting.enum.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.enum.italic=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.enumerator.color=141,218,248
/instance/org.eclipse.cdt.ui/semanticHighlighting.enumerator.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.externalSDK.color=150,236,63
/instance/org.eclipse.cdt.ui/semanticHighlighting.externalSDK.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.field.color=102,225,248
/instance/org.eclipse.cdt.ui/semanticHighlighting.field.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.function.color=167,236,33
/instance/org.eclipse.cdt.ui/semanticHighlighting.function.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.functionDeclaration.color=13,209,64
/instance/org.eclipse.cdt.ui/semanticHighlighting.functionDeclaration.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.functionDeclaration.bold=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.localVariable.color=255,191,38
/instance/org.eclipse.cdt.ui/semanticHighlighting.localVariable.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.localVariableDeclaration.color=237,127,72
/instance/org.eclipse.cdt.ui/semanticHighlighting.localVariableDeclaration.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.macroDefinition.color=13,209,64
/instance/org.eclipse.cdt.ui/semanticHighlighting.macroDefinition.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.macroDefinition.bold=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.method.color=167,236,33
/instance/org.eclipse.cdt.ui/semanticHighlighting.method.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.methodDeclaration.color=13,209,64
/instance/org.eclipse.cdt.ui/semanticHighlighting.methodDeclaration.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.methodDeclaration.bold=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.namespace.color=128,242,246
/instance/org.eclipse.cdt.ui/semanticHighlighting.namespace.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.parameterVariable.color=121,171,255
/instance/org.eclipse.cdt.ui/semanticHighlighting.parameterVariable.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.staticField.color=141,218,248
/instance/org.eclipse.cdt.ui/semanticHighlighting.staticField.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.staticMethod.color=150,236,63
/instance/org.eclipse.cdt.ui/semanticHighlighting.staticMethod.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.typedef.color=18,144,195
/instance/org.eclipse.cdt.ui/semanticHighlighting.typedef.enabled=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.typedef.bold=true
/instance/org.eclipse.cdt.ui/semanticHighlighting.typeParameter.color=191,164,164
/instance/org.eclipse.cdt.ui/semanticHighlighting.typeParameter.enabled=true

Comment 1 Doug Schaefer

2014-04-24 19:24:01 EDT

Will do. Thanks!

Comment 2 Lars Vogel

2014-04-27 16:55:56 EDT

Example how to register an extension to the dark theme can be found here https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=bc7c5eaf84573cd45d325f0f62f2d5009d07e6da

Comment 3 Doug Schaefer

2014-05-06 01:31:36 EDT

Here's how the JDT did it: https://git.eclipse.org/r/#/c/26006/

Comment 4 Doug Schaefer

2014-05-06 12:41:12 EDT

Change request submitted: https://git.eclipse.org/r/26066

Comment 5 Doug Schaefer

2014-05-06 13:59:09 EDT

Change was submitted. Thanks, Lars. These values look very nice.

Comment 6 Lars Vogel

2014-05-06 14:12:00 EDT

(In reply to Doug Schaefer from comment #5)
> Change was submitted. Thanks, Lars. These values look very nice.

Great to hear. Andrea (cc'ed) did the color schema.

Comment 7 Andrey Loskutov

2015-04-28 04:13:33 EDT

This change made impossible to run CDT on Eclipse 3.8, since org.eclipse.e4.ui.css.swt.theme is not existing there.

Can we please make this dependency optional?