Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 433056

Summary:	[contentAssist] testFiltering is failing
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Editor	Assignee:	Elijah El-Haddad <elijahe>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	5.0
Target Milestone:	6.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2014-04-17 17:53:31 EDT

The testFiltering case in /js-test/editor/contentAssist/test.html started failing recently. Probably due to a change in order-of-events from the fix for bug 432953.

The real-life editor seems to filter fine, so we need to fix the tests to correctly test what is actually happening there.

Comment 1 Elijah El-Haddad

2014-04-22 17:30:03 EDT

Pushed the following to eclipse.org:
- Added text view listeners as soon as content assist is activated
- Prevented content assist from filtering undefined or null proposals
- Refactored web/orion/editor/contentAssist.js to clean up the code and make it more maintainable/readable
- Added 3 new content assist filtering tests

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=648fb58ffdef926f5c1446027b7f217b1aaa3d7d

Comment 2 Elijah El-Haddad

2014-04-22 18:25:58 EDT

One more: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=94f61269032994f0a54ae7255c0744d7714f54c7