Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 432958

Summary:	Unzip confirmation dialog should be a yes/no dialog
Product:	[ECD] Orion	Reporter:	Elijah El-Haddad <elijahe>
Component:	Client	Assignee:	Elijah El-Haddad <elijahe>
Status:	RESOLVED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3
Version:	6.0
Target Milestone:	---
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Elijah El-Haddad

2014-04-16 14:57:19 EDT

The confirmation dialog which appears before a .zip file is uploaded asking the user if they'd like to unzip the file is a vanilla JavaScript window.confirm() dialog. This dialog asks the user the following question: "Unzip <file name>?" and gives them "OK" and "Cancel" buttons. However if the user clicks on "Cancel" the upload is not cancelled but rather the file is uploaded as is without being unzipped. 

This is confusing because the behavior of the Cancel button is in fact a "No" answer to the question that the confirm dialog is asking. The "No" option here is a valid one and therefore the dialog should be changed to a yes/no dialog. Clicking "No" will simply upload the file without unzipping it.

Comment 1 Elijah El-Haddad

2014-04-16 15:26:57 EDT

- Created an Orion ConfirmDialog class
pushed to eclipse.org: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f4dd0ff43efddb75fb5ac622bbcc98041fa0fbfa

Note that this dialog isn't currently being used anywhere but will be in future commits.

Comment 2 John Arthorne

2015-05-05 14:41:30 EDT

Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html