Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 432909

Summary:

Client may crash in IE7/8/9 due to implementation error in Parent._computeVisibleChildren

Product:

[RT] RAP

Reporter:

Tim Buschtoens <tbuschto>

Component:

RWT

Assignee:

Project Inbox <rap-inbox>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

mknauer, tbuschto

Version:

2.3

Target Milestone:

2.3 M3

Hardware:

All

OS:

All

Whiteboard:

Attachments:

Description	Flags
this.getElement().parentNode Null	none

Description Tim Buschtoens

2014-04-16 08:27:55 EDT

While I was not able to reproduce this issue at runtime myself, a customer reported client crashes in IE9 that I could trace back to Parent._afterInsertDom, "this.getElement().parentNode". This method throws an exception because getElement() returns null. _afterInsertDom is called via GraphicsMixin._prepareForCanvas -> Widget.prepareEnhancedBorder. The actual issue is in Parent._computeVisibleChildren, which returns widgets as "visible" that are not in the DOM, and _afterInsertDom fails as a result of that.

Comment 1 Markus Knauer

2014-04-16 08:36:23 EDT

Created attachment 242045 [details]
this.getElement().parentNode Null

Attaching a screenshot that shows the error message in the client. It doesn't really help to reproduce the error conditions, but it shows the problem with this.getElement().parentNode.

Comment 2 Tim Buschtoens

2014-04-17 05:03:58 EDT

Ready for Review: https://git.eclipse.org/r/#/c/25179/

Comment 3 Tim Buschtoens

2014-04-17 07:36:03 EDT

Fixed with commit d1d969e151c8a2079ccbe168559dd851fd0bee97