Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 432873

Summary:	dialog.js throws in _makeModal call
Product:	[ECD] Orion	Reporter:	Simon Kaegi <simon_kaegi>
Component:	Client	Assignee:	Simon Kaegi <simon_kaegi>
Status:	RESOLVED FIXED	QA Contact:
Severity:	blocker
Priority:	P3	CC:	elijahe, john.arthorne, libingw
Version:	5.0
Target Milestone:	6.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Simon Kaegi

2014-04-15 23:34:29 EDT

In particular this prevents the remote branch selection dialog from opening when pushing a branch.

Comment 1 Simon Kaegi

2014-04-15 23:35:36 EDT

For now I'm going to wrap this call in a try/catch swallower however we need to address this ASAP

Comment 2 libing wang

2014-04-16 09:00:24 EDT

If I revert this commit, the dialog shows the remote selection. http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=6a20c8f4ba9d2ef7c659ae8004d0f049755f3620

I guess this commit may affect other chained dialog?

Comment 3 libing wang

2014-04-16 09:01:56 EDT

(In reply to libing wang from comment #2)
> If I revert this commit, the dialog shows the remote selection.
> http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/
> ?id=6a20c8f4ba9d2ef7c659ae8004d0f049755f3620
> 
> I guess this commit may affect other chained dialog?

I meant the dialog.js part in this commit. Not the whole commit.

Comment 4 Elijah El-Haddad

2014-04-16 12:36:52 EDT

Pushed fix to eclipse.org: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=1ec1e556ca7c0fe9eba96fc2abe9217e41c12133

Comment 5 Simon Kaegi

2014-06-18 10:32:23 EDT