Bugzilla – Full Text Bug Listing
| Summary: | [Graphics] Problems view icons are wrong and washed out | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> | ||||||||
| Component: | IDE | Assignee: | Lars Vogel <Lars.Vogel> | ||||||||
| Status: | VERIFIED FIXED | QA Contact: | Lars Vogel <Lars.Vogel> | ||||||||
| Severity: | normal | ||||||||||
| Priority: | P3 | CC: | Lars.Vogel, markus.kell.r, tmccrary, tmccrary | ||||||||
| Version: | 4.0 | ||||||||||
| Target Milestone: | 4.4 M7 | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Whiteboard: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Dani Megert
Tony, can you provide an update? Screenshots? Created attachment 241788 [details]
Screenshot
The "warning" variant also needs to be fixed.
(In reply to Dani Megert from comment #3) > Created attachment 241788 [details] > Screenshot > > The "warning" variant also needs to be fixed. Okay should be an easy fix. Although, the left/right convention isn't really a convention, it's different all over the place on various icons (in the original gif set). (In reply to Tony McCrary from comment #4) > (In reply to Dani Megert from comment #3) > > Created attachment 241788 [details] > > Screenshot > > > > The "warning" variant also needs to be fixed. > > Okay should be an easy fix. Although, the left/right convention isn't really > a convention, it's different all over the place on various icons (in the > original gif set). That would be a mistake. Can you give examples where the error/warning decoration is on the right? Off hand, the quick fix icons. (In reply to Tony McCrary from comment #6) > Off hand, the quick fix icons. Good catch :-) (In reply to Tony McCrary from comment #6) > Off hand, the quick fix icons. There's a little difference in semantics, though: On resources, Java elements, and on the Problems view, the warning icon is an "Auxiliary or Status" icon that should be in the lower left corner, according to https://wiki.eclipse.org/User_Interface_Guidelines#Graphic_Types . On the other hand, the Quick Fix icons are action icons that should not look like an object with a warning/error attribute. It's not the lightbulb that has a problem. Having the warning/error on the lower left would convey a wrong message. For Quick Fix, the warning/error is a main component of the icon, and the lightbulb is only so big to ensure there's enough visual difference to the versions without a lightbulb. Ping! (In reply to Dani Megert from comment #9) > Ping! I have the icons done, I will do a commit. (In reply to Tony McCrary from comment #10) > (In reply to Dani Megert from comment #9) > > Ping! > > I have the icons done, I will do a commit. https://git.eclipse.org/r/#/c/25068/ Lars, can you prepare a Gerrit change that replaces the existing icons, so that we can see how they look in the product? Thanks. (In reply to Dani Megert from comment #12) > Lars, can you prepare a Gerrit change that replaces the existing icons, so > that we can see how they look in the product? Thanks. I believe Lars is on vacation, I will create a gerrit submission for platform ui. I create the patch next week Tuesday, sorry still in eastern vacation. New icons applied with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=0e78cff3acdbe14d87d0fa4e4c7f27a5fc2288b5 Dani, please reopen if you see additional issues. Tony, thanks again! Much better. The error icon is nice but in the warning icon, the warning is a bit too big and comes too much to the right, so that it looks more as being in the middle than on the left. Picture follows... Created attachment 242273 [details]
Screenshot of the problem
(In reply to Dani Megert from comment #17) > Created attachment 242273 [details] > Screenshot of the problem The warning icon is intentionally bigger to make it easier to discern. The old icon is somewhat distorted and hard to make out. So instead, the size is similar to the error variant, to make it look more uniform. (In reply to Tony McCrary from comment #18) > The warning icon is intentionally bigger to make it easier to discern. I'm not concerned about the size but with the fact that problem decorators must be on the lower left and this is no longer quickly grasp when looking at it. (In reply to Tony McCrary from comment #18) > (In reply to Dani Megert from comment #17) > > Created attachment 242273 [details] > > Screenshot of the problem > > The warning icon is intentionally bigger to make it easier to discern. The > old icon is somewhat distorted and hard to make out. So instead, the size is > similar to the error variant, to make it look more uniform. Dani, are you OK with the new icon or do you want to existing icon 1:1? I personally also prefer Tony version. (In reply to Lars Vogel from comment #20) > Dani, are you OK with the new icon or do you want to existing icon 1:1? I > personally also prefer Tony version. Sorry, you just answered, please ignore this comment. (In reply to Lars Vogel from comment #20) > (In reply to Tony McCrary from comment #18) > > (In reply to Dani Megert from comment #17) > > > Created attachment 242273 [details] > > > Screenshot of the problem > > > > The warning icon is intentionally bigger to make it easier to discern. The > > old icon is somewhat distorted and hard to make out. So instead, the size is > > similar to the error variant, to make it look more uniform. > > Dani, are you OK with the new icon or do you want to existing icon 1:1? I > personally also prefer Tony version. I like that one sees the warning better, but it should be more to the left (somehow). Created attachment 242295 [details] Show View Dialog (now vs. 4.3.2) The problems_view.png icon was also moved 1px to the left and expanded to also take the bottom-most pixel row, although https://wiki.eclipse.org/User_Interface_Guidelines#Icon_Size_.26_Placement recommends to leave those white. The reason for that recommendation is to leave enough space when icons are shown in a list, and to align the icons a bit, so that their placement looks orderly (unlike e.g. Problems and Progress view icons now do). Other icons (e.g. Outline) have the same problem. Once the base problems_view.png is back in shape, the warning overlay is automatically easier to see. (In reply to Markus Keller from comment #23) > Once the base problems_view.png is back in shape, the warning overlay is > automatically easier to see. And I just noticed that the yellow thing in the base base problems_view.png icon is a circle instead of a warning triangle. (In reply to Dani Megert from comment #24) > (In reply to Markus Keller from comment #23) > > Once the base problems_view.png is back in shape, the warning overlay is > > automatically easier to see. > > And I just noticed that the yellow thing in the base base problems_view.png > icon is a circle instead of a warning triangle. New Updates here: https://git.eclipse.org/r/#/c/25693/ It has the 1 pixel bottom border, the triangle is a pentagon now instead of rhombus and the warning sign is smaller. (In reply to Tony McCrary from comment #25) Thanks Tony, looks much better to me (especially the Problem view icon is really crisp). Marking as fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=b935fef5473f66a281a5b99f7f414207bdeef828 Dani / Markus please validate or reopen. Haven't heard anything bad from Dani or Markus. Marking as verified. (In reply to Lars Vogel from comment #27) > Haven't heard anything bad from Dani or Markus. Marking as verified. :-) |