Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 432369

Summary: Get rid of Orion ImportDialog
Product: [ECD] Orion Reporter: Elijah El-Haddad <elijahe>
Component: ClientAssignee: Elijah El-Haddad <elijahe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ahunter.eclipse
Version: 6.0   
Target Milestone: 6.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Attachments:
Description Flags
File with unicode characters in the filename none

Description Elijah El-Haddad CLA 2014-04-08 17:36:29 EDT 
The Orion ImportDialog, which is shown when a user attempts to import a file into a project from their local file system, is no longer useful. If users want to drag and drop files they can do so into the navigator. 

If users click on the "File->Import->File System" menu item they should be automatically taken to the system's file browser and allowed to select one or many files to import.

The same goes for the "File->New->Project->File System" command. This should also open the system's file browser automatically and then prompt users for a project name.
Comment 1 Elijah El-Haddad CLA 2014-04-08 17:57:40 EDT 
- Initial implementation which removes the use of ImportDialog from the "File->Import->File System" and "File->New->Project->File System" commands.
- Fixed error reporting in projectClient.js->createProject

pushed to eclipse.org: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=99231ba890666ab0e947c5dbc095389ebadfb22b
Comment 2 Anthony Hunter CLA 2014-04-16 15:08:05 EDT 
Created attachment 242070 [details]
File with unicode characters in the filename

I cannot import a file with unicode characters in the filename. The client UI gets stuck.

For example, try to import the attached file into a folder.
Comment 3 Anthony Hunter CLA 2014-04-16 15:10:51 EDT 
Actually I tried on orionhub and it is not working there either, so this was also broken in 5.0.
Comment 4 Elijah El-Haddad CLA 2014-04-23 14:43:57 EDT 
Pushed the following to eclipse.org:
- Deleted ImportDialog.js since it is no longer being used
http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=271ceae41bb384ca430df8a6ecbcba62ba3f212b




The issue mentioned by Anthony in comments 2 and 3 was unrelated and fixed under another bug.