Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 432221

Summary:	Snippet editor allows the same keyword twice
Product:	z_Archived	Reporter:	Andreas Sewe <sewe>
Component:	Recommenders	Assignee:	Olav Lenz <olav.lenz>
Status:	CLOSED FIXED	QA Contact:
Severity:	minor
Priority:	P3	CC:	sewe
Version:	unspecified	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:

Description Andreas Sewe

2014-04-08 03:33:34 EDT

In the Snippet Editor, you can add the same keyword twice. "Adding" an existing keyword should either be prevented in the "Enter new keyword" dialog or simply result in no effect. (Personally, I prefer the former solution, as it's less surprising to the user.)

Comment 1 Olav Lenz

2014-04-13 04:56:05 EDT

https://git.eclipse.org/r/#/c/24907/

Now the input dialog checks whether the user input already exists in the list of keywords or not. If it already exists the user isn't able to add his input it.

Comment 2 Andreas Sewe

2014-05-05 03:12:35 EDT

Fixed merged a while ago.

@Olav: If you submit a change in Gerrit, please don't hesitate set the associated bug to RESOLVED. (FYI, there's always a second step involved setting it to CLOSED to mark that it stood up to real-world usage.)

Comment 3 Marcel Bruch

2014-06-19 06:34:11 EDT

Closing for 2.1