Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 432103

Summary:	"Calculate Uses" doesn't work for x-internal/x-friends Export-Packages
Product:	[Eclipse Project] PDE	Reporter:	Andreas Sewe <sewe>
Component:	UI	Assignee:	PDE-UI-Inbox <pde-ui-inbox>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	normal
Priority:	P3	CC:	andrea.vai, curtis.windatt.public, psuzzi, tjwatson
Version:	4.4	Keywords:	helpwanted
Target Milestone:	---
Hardware:	PC
OS:	Mac OS X
Whiteboard:	stalebug

Description Andreas Sewe

2014-04-06 08:28:15 EDT

The "Calculate Uses" functionality of the manifest editor does not add uses directives for exported packages that are marked x-internal or x-friends. IMHO, this is a bug, as uses conflicts can of course arise for any exported package, whether flagged with x-internal/x-friends or not.

(FWIW, the PDE feature has version 3.10.0.v20140306-1200, from Luna M6)

Comment 1 Thomas Watson

2014-04-12 10:34:32 EDT

I don't think this should be enabled by default for x-internal.  The x-friends packages likely should get uses directives.  But x-internal packages really should just not be exported at all.  I would not want to have then get uses directives added that just adds extra data not needed.

Comment 2 Andreas Sewe

2014-04-14 03:38:33 EDT

(In reply to Thomas Watson from comment #1)
> I don't think this should be enabled by default for x-internal.  The
> x-friends packages likely should get uses directives.  But x-internal
> packages really should just not be exported at all.  I would not want to
> have then get uses directives added that just adds extra data not needed.

I beg to differ for three reasons:

- You say that "x-internal packages really should just not be exported at all". That may be so, but the fact is that packages marked x-internal exist in the wild.

- X-internal is an Equinox-specific directive. Other OSGi frameworks may ignore it and simply see the Export-Package.

- LinkageErrors at runtime (which you could get when doing an "internal import" without uses constraints) are IMHO always worse than the OSGi framework refusing to wire the bundles in the first place (which you will get when doing the same import with uses constraints).

Comment 3 Eclipse Genie

2019-09-13 11:56:51 EDT

This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.

Comment 4 Thomas Watson

2019-09-13 14:16:04 EDT

This is an old bug that I doubt will get any attention but it has prompted me to remember how much I dislike the practice of using x-internal at all ...

(In reply to Andreas Sewe from comment #2)
> - X-internal is an Equinox-specific directive. Other OSGi frameworks may
> ignore it and simply see the Export-Package.

This is true! and it is also now true for the Equinox framework as well because I dropped any support the framework had for x-internal and x-friends.  Note that by default the Equinox framework never did pay attention to these directives.  It was only if you configured it with "strict" mode would it pay attention to them.  I removed that strict option when moving the framework over to the common OSGi resolver implementation we share with apache Felix project.  I could be convinced x-friends is an OK idea because the Java module system (JPMS) has a similar concept with targeted exports.