Bugzilla – Full Text Bug Listing
| Summary: | [Intro] 'Workbench' button on Welcome page does not minimize the Welcome page but closes it | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> | ||||
| Component: | IDE | Assignee: | Brian de Alwis <bsd> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | bsd, Lars.Vogel, psuzzi | ||||
| Version: | 4.0 | ||||||
| Target Milestone: | 4.6 M5 | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| See Also: |
https://git.eclipse.org/r/63060 https://git.eclipse.org/r/65020 https://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=de5846610979bdc09d2cc46a2e0eb352707a3322 |
||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Dani Megert
Created attachment 241467 [details]
Picture of minimized Welcome page
I like it that the button closes it and see it as improvement. Dani, are you OK to set this bug to WONTFIX? (In reply to Lars Vogel from comment #2) > I like it that the button closes it and see it as improvement. > > Dani, are you OK to set this bug to WONTFIX? No, the [x] is for closing the welcome page. For new users that want to go to the workbench it's important that the welcome page functionality is still visible. Recently the Eclipse Foundation hired UIX experts and they recommend to use the button as close button. See Bug 466370. (In reply to Lars Vogel from comment #4) > Recently the Eclipse Foundation hired UIX experts and they recommend to use > the button as close button. See Bug 466370. Sure they do because currently it does close it, which is a bug, see comment 0. New Gerrit change created: https://git.eclipse.org/r/63060 This patch isn't quite sufficient: exceptions occur when dragging other trim elements. This is also complicated by the save on quit and restore. The complication is that the underlying intro code has mixed the UI and underlying configuration models such that IntroConfigurer assumes there is an already-created Intro Part. Specifically problematic here is that the IntroConfigurer#init() takes an IIntroSite, and is called from IntroPartPresentation#createPartControl(). All of this only matters as our model provides no way to mark an element as being transient so that it is either discarded before being persisted or on subsequent load. New Gerrit change created: https://git.eclipse.org/r/65020 Gerrit change https://git.eclipse.org/r/65020 was merged to [master]. Commit: http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=de5846610979bdc09d2cc46a2e0eb352707a3322 Fixed for 4.5M6. I had to make use of some Intro and UI internals that should be simplified. (In reply to Eclipse Genie from comment #10) > Gerrit change https://git.eclipse.org/r/65020 was merged to [master]. > Commit: > http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=de5846610979bdc09d2cc46a2e0eb352707a3322 > Brian, let's start with the positive thing: I verified in N20160122-2000 that the fix works. Thanks! There are several issues, some of which you should have seen in your IDE, assuming you have correctly set it up according to https://wiki.eclipse.org/Platform_UI/How_to_Contribute : - missing @since tag on new API IntroConfigurer.model - missing Javadoc on new API IntroConfigurer.model - missed to update the bundle version to 3.5.0, which had to be done due to the BREE increase and due to the new API - 242 new warnings in our official build: http://download.eclipse.org/eclipse/downloads/drops4/N20160122-2000/compilelogs/plugins/org.eclipse.ui.intro_3.4.300.N20160122-2000/@dot.html ==> one either have to fix those, or disable to issue those warnings in the official build. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=6196efec69002c56accc4ece2df16f96e0c8ea99 Brian, that commit makes IntroConfigurer.model private and disables the warnings. If the field needs to be protected, then please add Javadoc and @since tag. (In reply to Dani Megert from comment #12) > Fixed with > http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/ > ?id=6196efec69002c56accc4ece2df16f96e0c8ea99 > > Brian, that commit makes IntroConfigurer.model private and disables the > warnings. If the field needs to be protected, then please add Javadoc and > @since tag. I am ashamed to admit that I missed those warnings. Thanks for the fix! (In reply to Brian de Alwis from comment #13) > (In reply to Dani Megert from comment #12) > > Fixed with > > http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/ > > ?id=6196efec69002c56accc4ece2df16f96e0c8ea99 > > > > Brian, that commit makes IntroConfigurer.model private and disables the > > warnings. If the field needs to be protected, then please add Javadoc and > > @since tag. > > I am ashamed to admit that I missed those warnings. Thanks for the fix! There was another warning in the build which was not visible in the IDE since the warning was turned off. IntroLaunchBar#onPaint(PaintEvent) was not handling SideValue#TOP. I've added that case (do nothing). Please verify that this is the right thing. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ua.git/commit/?id=61dacb833cdbd7f8ef8c72caab09c47efb443486 |