Bugzilla – Full Text Bug Listing
| Summary: | Stop renaming modules in the optimized build | ||
|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Mark Macdonald <mamacdon> |
| Component: | Releng | Assignee: | Mark Macdonald <mamacdon> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | ||
| Version: | 5.0 | ||
| Target Milestone: | 6.0 M1 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | 383004 | ||
| Bug Blocks: | |||
Fixed, see commits http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=ed636ea http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=803def5 Posted summary to orion-dev https://dev.eclipse.org/mhonarc/lists/orion-dev/msg02942.html Will update wiki re: new build instructions soon. |
The current Orion JS build strategy includes a step where each optimized page/plugin module "foo/bar/{name}.js" is renamed to "built-{name}.js". To make that work, the module ID is updated within built-{name}.js using a textual find/replace. Any other modules that load "{name}.js" are then changed to load "built-{name}.js" instead. This is fragile, and becomes unworkable when an optimized module is loaded by several callers. AFAICT, the intent is to preserve the unminified {name.js} in the published build, for debugging. Once source maps support is in place, we should stop changing the module IDs. The unminified files will be available as {name}.js.src, and we can publish those in the build instead.