Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 431635

Summary:

[CSS] [dark theme] Remove gradient from Section headers in Form editors

Product:

[Eclipse Project] Platform

Reporter:

Lars Vogel <Lars.Vogel>

Component:

Assignee:

Simon Scholz <simon.scholz>

Status:

VERIFIED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

Lars.Vogel, peter, simon.scholz

Version:

4.4

Target Milestone:

4.5 M5

Hardware:

OS:

Linux

Whiteboard:

Bug Depends on:

430205

Bug Blocks:

Attachments:

Description	Flags
e4-dark_globalstyle.css from patch https://git.eclipse.org/r/#/c/23565	none
Screenshot	none
Section title without gradient	none
Section title with with better looking gradient	none

Description Lars Vogel

2014-03-31 09:43:54 EDT

Comment 1 Lars Vogel

2014-12-16 15:12:50 EST

Bug 430205 removes the hard-coded gradient in form section. Once we have fixed this, we should change our CSS for the dark theme to avoid the gradient which looks really bad on the dark theme.

Simon, could you provide a patch for the dark CSS to demonstrate the change from Bug 430205?

Comment 2 Simon Scholz

2014-12-16 15:23:11 EST

Created attachment 249481 [details]
e4-dark_globalstyle.css from patch https://git.eclipse.org/r/#/c/23565

Comment 3 Simon Scholz

2014-12-16 15:23:57 EST

In patch https://git.eclipse.org/r/#/c/23565/ there already is an updated version of the e4-dark_globalstyle.css

Comment 4 Lars Vogel

2014-12-16 15:27:23 EST

(In reply to Simon Scholz from comment #3)
> In patch https://git.eclipse.org/r/#/c/23565/ there already is an updated
> version of the e4-dark_globalstyle.css

https://git.eclipse.org/r/#/c/23565/ contains also other fixes for the missing reset. Could you extract the changes for CSS and create a new review for that which depends only on the changes of https://git.eclipse.org/r/#/c/37145/?

Comment 5 Simon Scholz

2014-12-16 15:41:58 EST

Now the css patch depends on https://git.eclipse.org/r/#/c/37145/

See https://git.eclipse.org/r/#/c/38381/

Comment 6 Lars Vogel

2014-12-16 16:52:00 EST

Created attachment 249484 [details]
Screenshot

For me this patch does not work, see attachment. Anything special I need to do to test this? Please note that I removed the "reset forms" commit from the list of dependencies, my assumption is that the gradient development and the CSS change should not depend on the other change.

Comment 7 Simon Scholz

2015-01-07 10:11:19 EST

Created attachment 249757 [details]
Section title without gradient

Here is a sample of a Section without gradient.

See https://git.eclipse.org/r/#/c/38381/ to see the implementation.

Comment 8 Simon Scholz

2015-01-07 10:16:45 EST

Created attachment 249758 [details]
Section title with with better looking gradient

In this attachment I'd like to show the result of the previous revision of my patch (https://git.eclipse.org/r/#/c/38381/5), where the border is white and there is still a gradient, but a better looking one.

I added this in order to show what is now possible with the CSS, but in my opinion current revision looks best.

Comment 9 Lars Vogel

2015-01-08 04:16:23 EST

(In reply to Simon Scholz from comment #5)
> Now the css patch depends on https://git.eclipse.org/r/#/c/37145/
> 
> See https://git.eclipse.org/r/#/c/38381/

Thanks Simon for your patience. Merged with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=fd977d6d5ef602a60cff24881547d5fc57b12e56

Comment 10 Lars Vogel

2015-01-28 10:07:32 EST

Validated via the dark theme in 4.5.0.I20150126-2000. The new gradient has a drawing issue, I follow up on this via Bug 430205.