Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 431510

Summary:	Avoid 'widget is disposed' while using the org.eclipse.sirius.eef.adapters.sectionFilters extension point
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Core	Assignee:	Maxime Porhel <maxime.porhel>
Status:	CLOSED FIXED	QA Contact:	Pierre-Charles David <pierre-charles.david>
Severity:	normal
Priority:	P3	CC:	florian.barbin, pierre-charles.david
Version:	1.0.0M6	Keywords:	triaged
Target Milestone:	1.0.0M7
Hardware:	PC
OS:	Windows NT
Whiteboard:

Description Maxime Porhel

2014-03-28 11:47:40 EDT

When the org.eclipse.sirius.eef.adapters.sectionFilters extension point is used to 

The problem is in fr.obeo.dsl.viewpoint.eef.section.SectionDescriptor.getSectionClass(). This SectionDescriptor stores the instance of ISection.
The standard SectionDescriptor (org.eclipse.ui.internal.views.properties.tabbed.view) creates a new instance each time the getSectionClass() is called.
In our case, fr.obeo.dsl.viewpoint.eef.section.SectionDescriptor.getSectionClass() returns a ISection with disposed controls. This explains the "Widget is disposed".

Comment 1 Maxime Porhel

2014-03-28 11:50:30 EDT

The Sirius rebranded class is org.eclipse.sirius.eef.section.SectionDescriptor

Comment 2 Maxime Porhel

2014-03-28 12:00:23 EDT

See https://git.eclipse.org/r/24076

Comment 3 Pierre-Charles David

2014-04-22 07:53:25 EDT

Maxime, the review you mention in the previous comment has been merged on master. Is there anything left to do here or can we close this?

Comment 4 Pierre-Charles David

2014-04-29 03:12:51 EDT

From what I see in the commit I'll consider this fixed for M7. Maxime, please reopen for 1.0 if you think there is more stuff to do.

Comment 5 Maxime Porhel

2014-05-05 03:02:15 EDT

This correction have been reported on Sirius from a correction done on a previous version of the tool. We can close it.

Comment 6 Pierre-Charles David

2014-05-05 07:32:33 EDT

Maxime, can you provide reproduction steps so that the fix can be verified?

Comment 7 Pierre-Charles David

2014-05-05 10:19:11 EDT

Verified on 1.0.0M7rc1 (1.0.0.20405030833).

Comment 8 Pierre-Charles David

2014-05-12 03:46:13 EDT

Available in Sirius 1.0.0M7 (see https://wiki.eclipse.org/Sirius/1.0.0M7 & http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/tag/?id=v1.0.0M7).