Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 431390

Summary:	RefreshOnOpening preference management should be moved in dialect ui.
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Core	Assignee:	Maxime Porhel <maxime.porhel>
Status:	CLOSED FIXED	QA Contact:	Julien Dupont <julien.dupont>
Severity:	normal
Priority:	P3	CC:	julien.dupont
Version:	1.0.0M6	Keywords:	triaged
Target Milestone:	1.0.0M7
Hardware:	PC
OS:	Windows NT
Whiteboard:
Bug Depends on:
Bug Blocks:	427803

Description Maxime Porhel

2014-03-27 12:44:46 EDT

DialectManager.setRefreshOnOpening() could let a developer think that he has the possibility to programmatically change this behavior, but this is called directly on reaction to changes in the preference page without any checks. It should removed.

Furthermore this corresponds to UI behavior and preference. 
The isRefreshActivatedOnRepresentationOpening() method should be moved to
DialectUIManager to directly call the preference service. 

DesignerUIPreferencesKeys.PREF_REFRESH_ON_REPRESENTATION_OPENING is a UI preference.

A cleanup step to rebrand DesignerUIPreferencesKeys into SiriusUIPreferenceKeys should be done before the correction of this issue.

Comment 1 Maxime Porhel

2014-03-27 12:50:57 EDT

See https://git.eclipse.org/r/23934 and https://git.eclipse.org/r/23935

Comment 2 Maxime Porhel

2014-03-28 10:36:51 EDT

Fixed in commits 
 . https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=b6bcacd2043f6eac174854d959200140554de8b2
 . https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=0788d2d83f6a5a7eba39f9233d21ca0d768b9f5c

Comment 3 Pierre-Charles David

2014-05-12 03:46:15 EDT

Available in Sirius 1.0.0M7 (see https://wiki.eclipse.org/Sirius/1.0.0M7 & http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/tag/?id=v1.0.0M7).