Bugzilla – Full Text Bug Listing
| Summary: | [CLA] Push commit refused because CLA reported signed-off but is valid | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Community | Reporter: | Francis Giraldeau <francis.giraldeau> | ||||
| Component: | Gerrit | Assignee: | Eclipse Webmaster <webmaster> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | denis.roy, thanh.ha | ||||
| Version: | unspecified | ||||||
| Target Milestone: | --- | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
|
Description
Francis Giraldeau
Francis, are you sure you are only pushing exactly 1 new commit? Might be worth running "gitk" or similar and confirming that you are only 1 commit ahead of origin/master. I rebased just prior to try pushing, and I confirm that the problem is the same. (In reply to Francis Giraldeau from comment #2) > I rebased just prior to try pushing, and I confirm that the problem is the > same. Rebasing does not guarantee that you only have 1 commit though which is what I was hoping to confirm that you are only pushing exactly 1 new commit for review. There's a problem with the CLA check plugin that if another commit has incorrect CLA issues it could be masked by the last commit as the plugin only returns result of one commit. I don't see any issues with your account in Gerrit or LDAP so I forced Gerrit to flush it's caches, can you check if that helped any? I confirm that the cache flush fixed the issue, the commit was accepted. We should consider a permanent fix, because there seems to be quite a few people affected by this problem. Why does the cache of CLA is not refreshed properly? Thanks! I've changed Gerrit's 10 min. cache value to 30 seconds.
[cache "ldap_groups"]
maxAge = 30 sec
I think we need to restart Gerrit for the change to take effect.
(In reply to Denis Roy from comment #5) > I've changed Gerrit's 10 min. cache value to 30 seconds. > > [cache "ldap_groups"] > maxAge = 30 sec > > I think we need to restart Gerrit for the change to take effect. Yes, that's right. I signed the CLA and waited few hours, so I'm not sure how does the change from 10m to 30s is fixing the issue. hmmm... I wonder what other cache could be coming into play? OMG I'm so sorry, I said that the bug is fixed, but I actually pushed to another server by mistake. Pushing to gerrit is still producing the same error (with the most up-to-date rebase). (In reply to Francis Giraldeau from comment #9) > OMG I'm so sorry, I said that the bug is fixed, but I actually pushed to > another server by mistake. Pushing to gerrit is still producing the same > error (with the most up-to-date rebase). Can you attach a git-format-patch of your commit you are trying to push to this bug? Created attachment 241343 [details] Patch failing to push to gerrit The patch is attached. In addition, here is the git configuration: [remote "origin"] url = git://git.eclipse.org/gitroot/linuxtools/org.eclipse.linuxtools.git fetch = +refs/heads/*:refs/remotes/origin/* [branch "master"] remote = origin merge = refs/heads/master [remote "review"] url = ssh://fgiraldeauodl@git.eclipse.org:29418/linuxtools/org.eclipse.linuxtools.git push = HEAD:refs/for/master I'm seeing this in the Gerrit logs. [2014-03-27 15:41:34,653] WARN com.google.gerrit.server.auth.ldap.LdapRealm : Account francis.giraldeau@usherbrooke.ca not found, assuming empty group membership Did you create your account originally with another email then changed it? Yes it is the case, my previous email was francis.giraldeau@usherbrooke.ca and I changed it to francis.giraldeau@gmail.com (In reply to Francis Giraldeau from comment #13) > Yes it is the case, my previous email was francis.giraldeau@usherbrooke.ca > and I changed it to francis.giraldeau@gmail.com You should be able to push now. I figured out how to remove your old email from Gerrit's database and your account passes the CLA checker in Gerrit now. Thanks, I confirm it works: [francis@blob org.eclipse.linuxtools]$ git push review Counting objects: 56, done. Delta compression using up to 4 threads. Compressing objects: 100% (17/17), done. Writing objects: 100% (30/30), 7.10 KiB | 0 bytes/s, done. Total 30 (delta 12), reused 0 (delta 0) remote: Resolving deltas: 100% (12/12) remote: Processing changes: new: 1, refs: 1, done remote: ---------- remote: Reviewing commit: commit 7ed2c32bf6a144f29dc23dfe548f494bcdb6e05f 1395943017 ----sp remote: Authored by: Francis Giraldeau <francis.giraldeau@gmail.com> remote: remote: The author is not a committer on the project. remote: The author has a current Contributor License Agreement (CLA) on file. remote: The author has "signed-off" on the contribution. remote: remote: This commit passes Eclipse validation. remote: remote: New Changes: remote: https://git.eclipse.org/r/24026 remote: To ssh://fgiraldeauodl@git.eclipse.org:29418/linuxtools/org.eclipse.linuxtools.git * [new branch] HEAD -> refs/for/master |