Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 431209

Summary: Username and Password not stored after updating from 3.3.0 to 3.3.1
Product: [Technology] EGit Reporter: Flavio Donze <flavio.donze>
Component: CoreAssignee: Project Inbox <egit.core-inbox>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: benjamin.schwertfeger, danstrmecki, jawr, lukair1983, matthias.sohn, mlippert, phancox, robin, sascha, shaibal.mandal, t-oberlies
Version: 3.3   
Target Milestone: 3.3   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 431899    

Description Flavio Donze CLA 2014-03-26 06:10:35 EDT
After updating EGit from 3.3.0.201403021825-r to 3.3.1.201403241930-r. 

My username and password is not stored in "Secure Store" anymore.

For example, pulling on a repository prompts the login dialog, there I enter the password and check the "Store in Secure Store" checkbox.
Pull completes and I pull again on the same repository, login dialog appears again.

We are using the following URL type: https://username@host/...
Comment 1 Lukasz T. CLA 2014-03-26 16:26:28 EDT
I see I'm late Flavio:
https://bugs.eclipse.org/bugs/show_bug.cgi?id=431289

Glad someone else got the same scenario as I did. Hopefully the bug fix will be there soon.
Comment 2 Robin Stocker CLA 2014-03-27 03:32:42 EDT
*** Bug 431289 has been marked as a duplicate of this bug. ***
Comment 3 Robin Stocker CLA 2014-03-27 03:35:14 EDT
This bug was probably caused by the fixes for bug 338048.
Comment 4 Matthias Sohn CLA 2014-03-27 03:45:28 EDT
sigh, this code is a bit too complex

you are right it still doesn't work completely. Earlier most read-only operations didn't ask for credentials if they weren't persisted in secure store.

I am working on a patch.

As a workaround try to store credentials here:
- open repositories view
- find the fetch URL node under <repository> > Remotes > origin
- click "Change Credentials" and enter the credentials
Comment 5 Peter Hancox CLA 2014-03-27 03:58:42 EDT
Tried the workaroud.  This stored the credentials but after running the first synchronise they were removed again.
Comment 6 Matthias Sohn CLA 2014-03-28 10:57:16 EDT
*** Bug 431500 has been marked as a duplicate of this bug. ***
Comment 7 Matthias Sohn CLA 2014-03-30 17:53:27 EDT
proposed patch https://git.eclipse.org/r/#/c/24175/
Comment 8 Sascha Vogt CLA 2014-04-02 09:03:03 EDT
(In reply to Matthias Sohn from comment #7)
> proposed patch https://git.eclipse.org/r/#/c/24175/

Proposed patch is working with stable-3.3 - tested on OS X and Win7 with Kepler SR2
Comment 9 Flavio Donze CLA 2014-04-03 09:44:11 EDT
Just installed latest, EGit version from the nightly build update site (http://download.eclipse.org/egit/updates-nightly) to version 3.4.0.201404021411. 

Is the patch already part of this build? In my case the issue remains.
Comment 10 Matthias Sohn CLA 2014-04-03 12:08:58 EDT
(In reply to Flavio Donze from comment #9)
> Just installed latest, EGit version from the nightly build update site
> (http://download.eclipse.org/egit/updates-nightly) to version
> 3.4.0.201404021411. 
> 
> Is the patch already part of this build? In my case the issue remains.

no, it's still in review
https://git.eclipse.org/r/#/c/24175/ 
I hope to tag 3.3.2 soon to deliver the fix
Comment 11 Tobias Oberlies CLA 2014-04-15 10:09:00 EDT
I've just updated to EGit 3.3.2.201404151303 from http://download.eclipse.org/egit/updates-stable-nightly and this fixes the problem for me :)
Comment 12 Matthias Sohn CLA 2014-04-15 10:43:31 EDT
I forgot to close this bug

the patch was merged as a53a18e988714cd87934d1a7e29b3331b37542a8 to stable-3.3 and also merged to master
Comment 13 Martin Lippert CLA 2014-04-16 13:12:35 EDT
Any idea when a 3.3.2 release will be available?
Comment 14 Matthias Sohn CLA 2014-04-17 15:18:33 EDT
*** Bug 433006 has been marked as a duplicate of this bug. ***
Comment 15 Robin Stocker CLA 2014-04-18 08:54:48 EDT
(In reply to Martin Lippert from comment #13)
> Any idea when a 3.3.2 release will be available?

Matthias released 3.3.2 just now: http://dev.eclipse.org/mhonarc/lists/egit-dev/msg03450.html
Comment 16 Martin Lippert CLA 2014-04-18 09:22:39 EDT
That is awesome!!! Thanks a lot for the maintenance release and for letting me know. Much appreciated!!!