Bugzilla – Full Text Bug Listing
| Summary: | Remove ICompatibleWorkbenchPage and org.eclipse.ui.workbench.compatibility | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> |
| Component: | UI | Assignee: | Lars Vogel <Lars.Vogel> |
| Status: | VERIFIED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | daniel_megert, john.arthorne, Lars.Vogel, sptaszkiewicz |
| Version: | 4.4 | ||
| Target Milestone: | 4.5 M1 | ||
| Hardware: | PC | ||
| OS: | All | ||
| See Also: | https://bugs.eclipse.org/bugs/show_bug.cgi?id=496871 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 439743 | ||
|
Description
Lars Vogel
John, what's the risk of removing this plugin? It's not clear from the other bug if we removed support for the 2.0 plugins or if we decided to put it back. PW Dani, do we still support Eclipse 2.0 plug-ins in Luna? (In reply to Lars Vogel from comment #3) > Dani, do we still support Eclipse 2.0 plug-ins in Luna? No. But deleting them now after the API freeze is a no go. We can mark them now for deletion in the next release. I see you moved the bug to 4.5. Did you nark it for deletion? If not please do so, or file a bug to track this for Luna. Otherwise we won't delete it in 4.5. (In reply to Dani Megert from comment #5) > I see you moved the bug to 4.5. Did you nark it for deletion? If not please > do so, or file a bug to track this for Luna. Otherwise we won't delete it in > 4.5. Sorry, I thought moving this bug to 4.5 was the right think. I moved it back. > Did you nark it for deletion? I don't know that this mean. Where do I mark something for deletion? (In reply to Lars Vogel from comment #6) > (In reply to Dani Megert from comment #5) > > I see you moved the bug to 4.5. Did you nark it for deletion? If not please > > do so, or file a bug to track this for Luna. Otherwise we won't delete it in > > 4.5. > > Sorry, I thought moving this bug to 4.5 was the right think. I moved it > back. > > > Did you nark it for deletion? > > I don't know that this mean. Where do I mark something for deletion? /org.eclipse.platform.doc.isv/porting/removals.html (In reply to Dani Megert from comment #7) > /org.eclipse.platform.doc.isv/porting/removals.html Thanks, please review https://git.eclipse.org/r/25371 Applied with https://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=4ff8270cbfded1b28cc4665600ecec1f3fe789e2 as we have to close all bugs today or move them out to 4.5. Dani, can you verify if the description is OK? (In reply to Lars Vogel from comment #10) > Dani, can you verify if the description is OK? Not quite. The bug URL is wrong, and both, type and plug-in name should be inside <code>. I've fixed that and also replaced "The Eclipse platform ui team " with "we". Fixed with http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/?id=220b110bb35fd6f5b448e374264547783984cc0d Reopening to do the real work during 4.5. (In reply to Dani Megert from comment #11) > (In reply to Lars Vogel from comment #10) > > Dani, can you verify if the description is OK? > > Not quite. The bug URL is wrong, and both, type and plug-in name should be > inside <code>. I've fixed that and also replaced "The Eclipse platform ui > team " with "we". > > Fixed with > http://git.eclipse.org/c/platform/eclipse.platform.common.git/commit/ > ?id=220b110bb35fd6f5b448e374264547783984cc0d > > Reopening to do the real work during 4.5. Thanks. This Gerrit review removes the org.eclipse.ui.workbench.compatibility plug-in from the build and the Git repo: https://git.eclipse.org/r/#/c/23901/ https://git.eclipse.org/r/#/c/29940/ removes ICompatibleWorkbenchPage from org.eclipse.ui.workbench (In reply to Lars Vogel from comment #13) > https://git.eclipse.org/r/#/c/23901/ Applied with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=90184d2009e64b0763b121fc952b63cb9331598e (In reply to Lars Vogel from comment #14) > https://git.eclipse.org/r/#/c/29940/ removes ICompatibleWorkbenchPage from > org.eclipse.ui.workbench API tools did not report any issues with this change (to my surprise) so I committed it with https://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=708bfddad74e7ddcdd83db1ffe6dba1ef707020a For the update of the migration guide I opened Bug 439743 4.5.0.I20140804-2000 works fine AFAICS |