Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 431134

Summary: Improve error messages when uploading files/folders by dragging and dropping them into navigator
Product: [ECD] Orion Reporter: Elijah El-Haddad <elijahe>
Component: ClientAssignee: Elijah El-Haddad <elijahe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 6.0   
Target Milestone: 6.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Elijah El-Haddad CLA 2014-03-25 12:08:30 EDT
explorer-table.js' errorHandler() function has two bugs: 

1) It calls progress.setProgressResult(error) with an error object that doesn't have its Severity set and therefore the status message which appears shows up as a regular message with a green background and not with the error color and styling.

2) When an xhr timeout occurs the error object passed into the errorHandler() function contains the error message in it's .error property. This message should be extracted and the object passed into progress.setProgressResult(error) should have its Severity and Message properties set appropriately.
Comment 1 Elijah El-Haddad CLA 2014-03-25 12:21:22 EDT
- Made errorHandler() set error object's Severity appropriately if the error it receives is a "string" or an object with a .error property
- Refactored code inside _makeDropTarget to reuse errorHandler() where appropriate

http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=e0442ee3c74d8add00f9a6de17aca8162111664e