Bug 430938

Description David Williams 2014-03-22 14:18:09 EDT

I am fixing (at least, what I think is fixing) some of the overall "test.xml" variables, and how they handle running tests when various, specific VMs are available. 

And, I'm assuming some of the comments or logic in test.xml are either wrong, or unclear. So, this bug is to clarify what is desired and then I can fix documentation or logic depending on the answers. 

The question applies to these test bundles: 

org.eclipse.jdt.apt.tests
org.eclipse.jdt.apt.pluggable.tests
org.eclipse.jdt.compiler.tool.tests
org.eclipse.jdt.compiler.apt.tests
org.eclipse.pde.api.tools.tests

Since most apply to "jdt", that's where I will open the bug ... but the last one is a "PDE Question", I assume.

BTW, it may make it easier to answer if you know that my "fix" is to "assign" the variables such as J2SE-5.0 if there is a Java 5 VM, _or higher_ (previously, in some use cases, J2SE-5.0 would only be assigned if someone "externally" set J2SE-5.0. This means, basically, that we now (and, I think for some time) have been running all the tests with the same VM ... but some of the comments imply a test should be ran only if one specific level is available and defined.  I could "fix" things, so that multiple VMs could be defined and different levels used to run different tests, and if a test did not say, it'd simply be ran with the "default" (highest) VM defined -- but, I need to know what's desired, first.  

So, again, point is simply to clarify what's desired, then I can fix comments (or logic, if intent is to really run tests with different, specific VM levels) or to skip them, if that specific level is not defined. In intuition is that a lot of this is "left over" and "hacked up beyond recognition" once we started to move from Java 4 to Java 5 ... but, not sure. It is also possible something was lost in the transition from Kim to me, and in the transition of running on IBM machines, to running on "build.eclipse.org". 

In any case, pretty sure some will need to have logic "fixed" due to their "not defined" logic with their list of "or conditions" ... and in any case, a good time to better document what's desired. 

Case 1: 

  <target
    name="jdtapt"
    depends="setJVMProperties">
    <property
      name="jvm"
      value="${J2SE-5.0}" />
    <!--only run test if J2SE-5.0 property  set-->
    <condition property="skip.test">
      <not>
        <isset property="J2SE-5.0" />
      </not>
    </condition>
    <runTests testPlugin="org.eclipse.jdt.apt.tests" />
  </target>
  
*  I'm assuming this means to run the tests, if Java 6 or higher is available? And comment needs to be fixed?

Case 2: 

  <target
    name="jdtaptpluggable"
    depends="setJVMProperties">
    <property
      name="jvm"
      value="${J2SE-6.0}" />
    <!--only run test if J2SE-5.0 property  set-->
    <condition property="skip.test">
      <not>
        <or>
          <isset property="J2SE-6.0" />
          <isset property="J2SE-7.0" />
          <isset property="J2SE-8.0" />
        </or>
      </not>
    </condition>
    <runTests testPlugin="org.eclipse.jdt.apt.pluggable.tests" />
  </target>
  
*  I'm not sure what this means ... the "logic" of it is to literally run tests only if J2SE-6.0, but that contradicts comment, and the "skip.test" logic. 

Case 3: 

  <target
    name="jdtcompilertool"
    depends="setJVMProperties">
    <property
      name="jvm"
      value="${J2SE-6.0}" />
    <!--only run test if J2SE-6.0 property or greater is set-->
    <condition property="skip.test">
      <not>
        <or>
          <isset property="J2SE-6.0" />
          <isset property="J2SE-7.0" />
          <isset property="J2SE-8.0" />
        </or>
      </not>
    </condition>
    <runTests testPlugin="org.eclipse.jdt.compiler.tool.tests" />
  </target>


* Similar to case 2. 

Case 4:

  <target
    name="jdtcompilerapt"
    depends="setJVMProperties">
    <property
      name="jvm"
      value="${J2SE-6.0}" />
    <!--only run test if J2SE-6.0 property or greater is set-->
    <condition property="skip.test">
      <not>
        <or>
          <isset property="J2SE-6.0" />
          <isset property="J2SE-7.0" />
          <isset property="J2SE-8.0" />
        </or>
      </not>
    </condition>
    <runTests testPlugin="org.eclipse.jdt.compiler.apt.tests" />
  </target>

* Similar to case 3 and 2. 


Case 5: 

  <target
    name="pdeapitooling"
    depends="setJVMProperties">
    <property
      name="jvm"
      value="${J2SE-5.0}" />
    <!--only run test if J2SE-5.0 property  set-->
    <condition property="skip.test">
      <not>
        <isset property="J2SE-5.0" />
      </not>
    </condition>
    <runTests testPlugin="org.eclipse.pde.api.tools.tests" />
  </target>

* Similar to case 1 -- I assume means run the tests if Java 5 or higher is available?