Bugzilla – Full Text Bug Listing
| Summary: | [CSS] ACTIVE_TAB_BG_END must not be used to set view background and description background | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Dani Megert <daniel_megert> | ||||||||||||
| Component: | UI | Assignee: | Platform-UI-Inbox <Platform-UI-Inbox> | ||||||||||||
| Status: | RESOLVED WORKSFORME | QA Contact: | |||||||||||||
| Severity: | normal | ||||||||||||||
| Priority: | P3 | CC: | emoffatt, Lars.Vogel | ||||||||||||
| Version: | 4.4 | ||||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Hardware: | PC | ||||||||||||||
| OS: | Windows 7 | ||||||||||||||
| Whiteboard: | |||||||||||||||
| Bug Depends on: | 433276 | ||||||||||||||
| Bug Blocks: | 330117 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Dani Megert
Created attachment 241097 [details] The CTabItem snapshot (In reply to Dani Megert from comment #0) > The ACTIVE_TAB_BG_END must not be used to set view background and > description background. Only the border should get that color. Do you want to get the following effect - 'The CTabItem snapshot'? Created attachment 241098 [details]
The CTabItem snapshot with the 'e4 default' colors
(In reply to Daniel Rolka from comment #1) > Created attachment 241097 [details] > The CTabItem snapshot > > (In reply to Dani Megert from comment #0) > > The ACTIVE_TAB_BG_END must not be used to set view background and > > description background. Only the border should get that color. > > Do you want to get the following effect - 'The CTabItem snapshot'? Yes. Gerrit review link: https://git.eclipse.org/r/#/c/24546/ Daniel Daniel, could you please attach some CSS file(s) that I can use to check out the changes in the patch ? Also, a before / after screenshot with the same CSS would also help me test this out... (In reply to Eric Moffatt from comment #5) > Daniel, could you please attach some CSS file(s) that I can use to check out > the changes in the patch ? > > Also, a before / after screenshot with the same CSS would also help me test > this out... Just change it via preferences :-) Do we have a scheme that uses gradients on the tabs ? Created attachment 242217 [details] Issue in the 'e4 default blue' theme (In reply to Eric Moffatt from comment #7) > Do we have a scheme that uses gradients on the tabs ? Each 'e4 default' theme uses gradient on the tabs. Btw. regarding the gradients, I've noticed the issue in the patch that corrupts the 'e4 default blue' theme (see attachment). I will prepare the update for the patch that handles it Daniel (In reply to Daniel Rolka from comment #8) > Created attachment 242217 [details] > Issue in the 'e4 default blue' theme > Btw. regarding the gradients, I've noticed the issue in the patch that > corrupts the 'e4 default blue' theme (see attachment). I will prepare the > update for the patch that handles it > > Daniel OK, I've pushed the altered patch to Gerrit that solves the issue above for the 'e4 default blue' theme. It is not perfect (there is a little flicking of the toolbar during resizing the part), but it works fine. Having the Bug 433276 fixed we will be able to create sth better Daniel Created attachment 242228 [details]
With and without the patch
Let me attach small snapshot that presents what we are trying to achieve with this patch
Daniel
(In reply to Daniel Rolka from comment #10) > Created attachment 242228 [details] > With and without the patch > > Let me attach small snapshot that presents what we are trying to achieve > with this patch > > Daniel Your picture shows that the fix is not good yet: the borders around the view must keep the end color (as shown in the preview of the preference page). (In reply to Dani Megert from comment #11) > (In reply to Daniel Rolka from comment #10) > > Created attachment 242228 [details] > > With and without the patch > > > > Let me attach small snapshot that presents what we are trying to achieve > > with this patch > > > > Daniel > > Your picture shows that the fix is not good yet: the borders around the view > must keep the end color (as shown in the preview of the preference page). Argh! Looks like this is not broken by your fix but by some other change done after M6 (there the border is present). Filed bug 433514. (In reply to Dani Megert from comment #12) > Argh! Looks like this is not broken by your fix but by some other change > done after M6 (there the border is present). Filed bug 433514. With the fix for bug 433514 everything works as expected. Committed: http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=a84eb9a9f764a6dd3b9e2e65bf0cbcf22b091af4 Which color theme can I use to see this in action (i.e. like the screen cap) ? (In reply to Eric Moffatt from comment #14) > Committed: > > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/ > ?id=a84eb9a9f764a6dd3b9e2e65bf0cbcf22b091af4 > > Which color theme can I use to see this in action (i.e. like the screen cap) > ? Just set the color via preferences. (In reply to Eric Moffatt from comment #14) > Which color theme can I use to see this in action (i.e. like the screen cap) > ? For the 'With and without the patch' snaphot you have to use the 'Windows XP Blue' one Daniel Verified in the build: I20140428-2000 Daniel The fix for bug 434134 brought this one back. Created attachment 243072 [details] The gradient issue We have to have the patch for the bug 433276 in order to fix it properly, see the snapshot Daniel We recently changes the Windows theme to be more Win10 like so AFAICS this bug is obsolete. |