Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 430860

Summary: [GEF4] Java8 Support
Product: [Tools] GEF Reporter: Aykut Kilic <battalaykut>
Component: RelEngAssignee: Alexander Nyßen <nyssen>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: nyssen, zoltan.ujhelyi
Version: unspecified   
Target Milestone: ---   
Hardware: PC   
OS: Windows 8   
Whiteboard:

Description Aykut Kilic CLA 2014-03-21 05:46:56 EDT
GEF4 mvn build fails when JDK version is java8. Projects cannot be compiled because of unresolved javafx classes/packages.
Comment 1 Aykut Kilic CLA 2014-03-21 05:47:43 EDT
Here's a screenshot:
https://bugs.eclipse.org/bugs/attachment.cgi?id=241074
Comment 2 Zoltan Ujhelyi CLA 2014-03-21 05:49:38 EDT
In Java 8 the SWT support is moved out from the jfxrt.jar file. The easiest way to have it back should be to install the e(fx)clipse project, that fixes the classpath correctly (have not tested it yet, but it should work).
Comment 3 Alexander Nyßen CLA 2014-07-13 08:48:41 EDT
Actually, installing e(fx)clipse will not suffice, because it does not make these libs available for Maven. 

I will update the build scripts to include the jfxswt.jar for compilation and javadoc generation in Java 8 (as we already include the jfxrt.jar for Java7). That will do the trick.

Another thing I noticed is that Java 8's javadoc seems to fail on errors (Java 7 javadoc ignored these, only reporting them to the log file), which in turn lets our build fail (in case javadoc errors occur, which is currently the case). I will try to fix all the javadoc problems we currently have, but we should find a way how we can handle that uniformly on both platforms (or switch to Java 8 in our build job, so javadoc errors are directly reported).
Comment 4 Alexander Nyßen CLA 2014-07-13 14:40:36 EDT
I adjusted the builds scripts accordingly (added jfxswt.jar as an extra classpath argument to the compiler as well as to the javadoc classpath) and resolved all our javadoc errors (which was quite an effort). 

I verified locally and on hudson.eclipse.org that the maven build now runs with a Java 7 as well as a Java 8 jdk. All changes are committed origin/master. Changed the gef4-master build-job on hudson.eclipse.org to from now on use a Java 8 sdk by default, so we will not introduce unnoticed javadoc errors again. Resolving as fixed.