Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 430659

Summary:	[pmi] "Clone this repository" URLs pointing to Gerrit have an extra "/p"
Product:	Community	Reporter:	Tobias Oberlies <t-oberlies>
Component:	Project Management & Portal	Assignee:	Portal Bugzilla Dummy Inbox <portal-inbox>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	thanh.ha, wayne.beaton, webmaster
Version:	unspecified
Target Milestone:	2014-Q2
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Tobias Oberlies

2014-03-18 22:54:59 EDT

The URLs linking to the project's git repositories served by the Gerrit server have an extra "/p" segment in the URL.

Example from [1]: One of the URLs is https://git.eclipse.org/r/p/tycho/org.eclipse.tycho

According to Gerrit [2], it should be https://git.eclipse.org/r/tycho/org.eclipse.tycho

I think that the /r/p URLs do also work, but I don't really know why they do, so I wouldn't really rely on that. Also, there was some bug some time back in Gerrit that could be worked around by using the /r URL instead of the /r/p URL.


[1] https://projects.eclipse.org/projects/technology.tycho
[2] https://git.eclipse.org/r/#/admin/projects/tycho/org.eclipse.tycho
[3] https://wiki.eclipse.org/Tycho/Contributor_Guide

Comment 1 Wayne Beaton

2014-03-25 16:44:37 EDT

When I implemented this, "/r/p" must have been part of the path (I'm pretty sure that I didn't make this up).

Webmaster, can I safely assume that the "/r" option is the most correct?

Comment 2 Thanh Ha

2014-03-26 09:27:14 EDT

I'm pretty confident the /p is no necessary at all. I have never used that addressing personally.

Comment 3 Wayne Beaton

2014-05-20 14:32:11 EDT

/r/egit/egit-pde is invalid.

/r/p/egit/egit-pde is short form for /r/#/q/status%3Aopen+project%3Aegit/egit-pde,n,z

which takes you to the open contributions.

/r/#/admin/projects/egit/egit-pde goes to the "admin" page.

I'm inclined to change this to point to the admin page. Thoughts?

Comment 4 Tobias Oberlies

2014-05-21 05:34:35 EDT

(In reply to comment #3)
> I'm inclined to change this to point to the admin page. Thoughts?

The problem that I wanted to report is the link for cloning the repository, not about the browser link.

/r/egit/egit-pde is valid for cloning the repository.

Comment 5 Tobias Oberlies

2014-08-22 12:55:20 EDT

(In reply to comment #4)
> /r/egit/egit-pde is valid for cloning the repository.

You can see this in the Gerrit UI here [1] under "Anonymous HTTP"

[1] https://git.eclipse.org/r/#/admin/projects/egit/egit-pde

Comment 6 Wayne Beaton

2014-08-26 12:58:36 EDT

So I fixed this, but then uncovered a different problem.

I'm using the same URL for the clone line and for the "Review with Gerrit" link. The clone link isn't helpful for the "Review" link.

Comment 7 Wayne Beaton

2014-10-02 00:15:36 EDT

I've reworked how I harvest and display repository information. 

We now render:

a "browse" link that points to cgit;
a "review" link if the project uses Gerrit;
some "clone" text that points to Gerrit if the project uses Gerrit, or Git otherwise.