Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 430527

Summary: Fix all packaging issues identified by the automated reports
Product: [Modeling] Sirius Reporter: Pierre-Charles David <pierre-charles.david>
Component: RelengAssignee: Pierre-Charles David <pierre-charles.david>
Status: CLOSED FIXED QA Contact: Maxime Porhel <maxime.porhel>
Severity: normal    
Priority: P3 CC: julien.dupont, maxime.porhel
Version: unspecifiedKeywords: triaged
Target Milestone: 1.0.0M7   
Hardware: All   
OS: All   
Whiteboard:

Description Pierre-Charles David CLA 2014-03-17 10:51:13 EDT
The automatic reports at http://build.eclipse.org/simrel/luna/reporeports/ identify several issues which concern Sirius. Most seem trivial (e.g. about.html files present but not mentioned in the build.properties file). We should fix all of them for M7.
Comment 1 Pierre-Charles David CLA 2014-03-18 05:26:14 EDT
From what I understand of http://build.eclipse.org/simrel/luna/reporeports/reports/providerNames.html, it seems we should be using "Eclipse Modeling Project" as ou provider name instead of the "old style" "Eclipse.org" one. I need to check with Cédric before actually making the change.
Comment 2 Pierre-Charles David CLA 2014-03-18 05:27:03 EDT
From http://build.eclipse.org/simrel/luna/reporeports/reports/pack200data.txt, it looks like we do not correctly package our JARs. We'll need to investigate how to change our builds to produce pack200 files.
Comment 3 Pierre-Charles David CLA 2014-03-18 05:43:56 EDT
See https://git.eclipse.org/r/23521 and https://git.eclipse.org/r/23522 for the easy fixes.
Comment 4 Pierre-Charles David CLA 2014-03-24 11:07:24 EDT
See also https://git.eclipse.org/r/#/c/23806/
Comment 5 Pierre-Charles David CLA 2014-03-31 08:33:39 EDT
https://wiki.eclipse.org/Tycho/Pack200 seems to have the instructions to fix the pack200 issue.
Comment 6 Pierre-Charles David CLA 2014-04-01 11:08:30 EDT
See commit bdac8cbca10a808fd81ba3ff5fddca80fd0fd0b9 for the packing.
Comment 7 Pierre-Charles David CLA 2014-04-02 03:35:05 EDT
After several tries, commits d8d297a16ec0102d5626c74e31bef9894d53dbbb and 8b35588625b632bdefb04ed1f0d6445a5d1c0a80 seem to fix the packing issue. The latest nightly (at http://download.eclipse.org/sirius/updates/nightly/1.0.0-N20140401-160806/luna/plugins/?d) contains both *.jar and *.jar.pack.jz files (except for the sources, where it is normal, and the paperclips bundle we provide ourselves).
Comment 8 Pierre-Charles David CLA 2014-04-02 04:03:45 EDT
The last remaining problem, about provideName, is fixed by commit 8a5c257ef8141264fbc7c015e5f618c4eeea30cd.
Comment 9 Pierre-Charles David CLA 2014-04-24 05:43:25 EDT
From http://build.eclipse.org/simrel/luna/reporeports/reports/licenseConsistency.html, it seems we use an old version of the license text. It looks like using the Eclipse license feature should fix the issue, see how the JDT does it at:

http://git.eclipse.org/c/jdt/eclipse.jdt.git/tree/org.eclipse.jdt-feature/feature.xml#n7

It is not clear whether or not this makes some of the files/properties we currently have for each feature obsolete and what could/should be removed (for exemple do we still need a copy of epl-v10.html everywhere?).
Comment 10 Pierre-Charles David CLA 2014-04-24 06:37:03 EDT
See bug 431255 for more details about the license update.
Comment 11 Pierre-Charles David CLA 2014-04-24 08:18:17 EDT
See also the discussion starting at https://dev.eclipse.org/mhonarc/lists/cross-project-issues-dev/msg10501.html
Comment 12 Pierre-Charles David CLA 2014-04-25 10:22:58 EDT
Example of another project (GEF4) updating to use the shared license plug-in: http://git.eclipse.org/c/gef/org.eclipse.gef4.git/commit/?id=3b980a8fe154a90e9eb917ceda928d9c65205341
Comment 13 Pierre-Charles David CLA 2014-04-29 05:25:29 EDT
See https://git.eclipse.org/r/#/c/25713/.
Comment 14 Pierre-Charles David CLA 2014-04-29 05:44:41 EDT
Fixed by f358e777854db152aa3071a86e5f9101a1cf3246.
Comment 15 Maxime Porhel CLA 2014-05-05 11:32:30 EDT
Verified on http://build.eclipse.org/simrel/luna/reporeports/

There are no issue which concern Sirius.
 
Several Sirius ext plugins are shown with a questionable BREE presence: they do not contains java code yet but they already declare a BREE.
Comment 16 Pierre-Charles David CLA 2014-05-12 03:45:52 EDT
Available in Sirius 1.0.0M7 (see https://wiki.eclipse.org/Sirius/1.0.0M7 & http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/tag/?id=v1.0.0M7).