Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 430432

Summary: editor command shortcut no longer works
Product: [ECD] Orion Reporter: Rafael Chaves <eclipse>
Component: EditorAssignee: Project Inbox <orion.editor-inbox>
Status: RESOLVED WONTFIX QA Contact:
Severity: normal    
Priority: P3 CC: Silenio_Quarti
Version: 5.0   
Target Milestone: ---   
Hardware: PC   
OS: Linux   
Whiteboard:

Description Rafael Chaves CLA 2014-03-14 23:35:34 EDT
I wrote an editor command contribution that used to work fine in 4.0 and before, but no longer can be triggered via shortcut in 5.0. The command itself works (using the Tools menu), but the shortcut won't. Another built-in editor command is working fine, so my guess is there was a non-backwards compatible change in how shortcuts work.

This is my command contribution:

provider.registerServiceProvider("orion.edit.command", {
    run : autoFormat
}, {
    name : "Format (^M)",
    key : [ "m", true ],
    contentType: ["text/uml"]
});
Comment 1 Silenio Quarti CLA 2014-03-19 16:13:50 EDT
Ctrl+M is taken by the editor to toggle tab mode.  I do not think this is new in 5.0 though.

Does the key binding work if the editor is not in focus? 

Does it only fail with Ctrl+M? Or any shortcut?
Comment 2 Rafael Chaves CLA 2014-03-19 16:18:26 EDT
It used to work in 4.0-ish (RC2 maybe?). If you feel like trying it, check out http://develop.cloudfier.com - check out a sample project, open a .tuml file,  mess with the formatting a bit and hit ^M. 

I can pick another shortcut if that is all it is though.

The Git blame command (provided by Orion) is working fine for me (see comment #0).

I haven't tried the shortcut when outside of the editor, didn't expect that to work, will try later and report back (will change the shortcut as well).
Comment 3 Rafael Chaves CLA 2014-03-20 05:58:39 EDT
Silenio, to be clear, that server is still based on 4.0-ish. Just in case you wanted to see the shortcut working. I have yet to deploy a new 5.0 version.
Comment 4 John Arthorne CLA 2015-05-05 14:44:51 EDT
Closing as part of a mass clean up of inactive bugs. Please reopen if this problem still occurs or is relevant to you. For more details see:

https://dev.eclipse.org/mhonarc/lists/orion-dev/msg03444.html