Bugzilla – Full Text Bug Listing
| Summary: | [CSS] Provide CSS handler for Forms Section element | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Lars Vogel <Lars.Vogel> | ||||||||||
| Component: | UI | Assignee: | Simon Scholz <simon.scholz> | ||||||||||
| Status: | VERIFIED FIXED | QA Contact: | |||||||||||
| Severity: | normal | ||||||||||||
| Priority: | P3 | CC: | daniel.rolka, daniel_megert, Lars.Vogel, mihael, peter, simon.scholz | ||||||||||
| Version: | 4.4 | ||||||||||||
| Target Milestone: | 4.5 M5 | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Linux | ||||||||||||
| Whiteboard: | |||||||||||||
| Bug Depends on: | 430205 | ||||||||||||
| Bug Blocks: | |||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Lars Vogel
Created attachment 240898 [details]
Screenshot
I think for this we require an additional plug-in to avoid a dependency conflict. I suggest to call it: org.eclipse.e4.ui.css.forms I create a first version of it, but it would be great if Daniel good review that, as he has written the reset for the SWT CSS. I try to solve this together with Bug 430205 https://git.eclipse.org/r/23565 To test this change switch between dark and light themes with a "Section" in an editor open. Moving to 4.5 as of Pauls request, I plan to see if I still can get that fixed and applied for 4.4 as it is pretty annoying for the dark theme. Moving back to RC1. Here is some related discussion in IRC: http://echelog.com/logs/browse/eclipse-e4/1395702000 I just rebased the patch from Lars and added also the styling for the title bar border. See: https://git.eclipse.org/r/#/c/23565/ (In reply to Simon Scholz from comment #8) > I just rebased the patch from Lars and added also the styling for the title > bar border. > > See: https://git.eclipse.org/r/#/c/23565/ Can you add a screenshot how the title bar looks like? I would prefer a solid color (start gradient == end gradient). Created attachment 248970 [details]
The border of the titblebar is white and its background is also dark(#6D5E5E)
(In reply to Lars Vogel from comment #9) > Can you add a screenshot how the title bar looks like? I would prefer a > solid color (start gradient == end gradient). Solid color is handled by Bug 430205. (In reply to Simon Scholz from comment #8) > See: https://git.eclipse.org/r/#/c/23565/ This does not work for me, I attach a before switching to dark screenshot and a after switching to dark and back screenshot. I would expect that the forms UI looks the same after switching back from dark to GTK. Created attachment 249448 [details]
Before
Created attachment 249449 [details]
After
(In reply to Lars Vogel from comment #12) > (In reply to Simon Scholz from comment #8) > > See: https://git.eclipse.org/r/#/c/23565/ > After some rework from Simon, merged with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9b58903d98a9c85379b836c057b94d514c238899 (In reply to Lars Vogel from comment #15) > (In reply to Lars Vogel from comment #12) > > (In reply to Simon Scholz from comment #8) > > > See: https://git.eclipse.org/r/#/c/23565/ > > > After some rework from Simon, merged with > http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=9b58903d98a9c85379b836c057b94d514c238899 > I don't think you really wanted to introduce two new API packages. I've converted them to internal and registered them in the manifest. I've also increased the bundle version as required by https://wiki.eclipse.org/Version_Numbering. Fixed with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e87165eb4754a41bfcf18cc674260f099c5daaa1 Thanks Dani for watching out. Validated via the dark theme in 4.5.0.I20150126-2000. The new gradient has a drawing issue, I follow up on this via Bug 430205. |