| Summary: | Add support for RGBA or 'transparent' color | ||
|---|---|---|---|
| Product: | [Eclipse Project] Platform | Reporter: | Andrea Guarinoni <andrea.guarinoni> |
| Component: | SWT | Assignee: | Stefan Winkler <stefan> |
| Status: | RESOLVED DUPLICATE | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | bsd, daniel.rolka, daniel_megert, Lars.Vogel, niraj.modi, stefan |
| Version: | 4.4 | ||
| Target Milestone: | 4.5 M5 | ||
| Hardware: | PC | ||
| OS: | Windows 7 | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 430848 | ||
|
Description
Andrea Guarinoni
I'm not sure if we are able to fix it without the SWT modification. Maybe we can generate proper images and use it as the background, but it is the workaround in my opinion Daniel We can at least handle transparency for Button and Label widgets. If both background and backgroundImage are set to null for these widgets, they return drawsBackground() == false which has the effect of having a transparent background. See my patch here: https://git.eclipse.org/r/25276 I'm weakly -1 on this change (and I'm sorry I haven't gotten to the "inherit" change). I think the use of reflection reflects my problem with this proposal change: I don't think SWT truly supports "transparent" but "inherit". But SWT and CSS's use of heredity seem different. CSS can toggle inheritance on a per-child basis where as SWT controls this using the background-mode. But I haven't delved sufficiently into how they differ, or how we can map one to the other. My fear is that we already have some behaviour that is fundamentally opposite to the CSS standard (viz margin and padding in bug 364070), and we might introduce conflicts with inherit and transparency. Stefan, would you mind looking deeper at the CSS standards and summarize how transparency and inherit might map to SWT? Hi Brian, thanks for your comments on this issue and on Bug 419377. I'll go ahead and investigate what the CSS specs say; I will need some time though. It has to be mainly fixed on the SWT site. Next we can update the CSSEngine with the change Daniel SWT has now has support for transparency, see https://www.eclipse.org/eclipse/news/4.5/M5/ or Bug 435384. For SWT it is just another color so I think there is nothing left for platform to do. To use this in our themes we should open a new bug. *** This bug has been marked as a duplicate of bug 435384 *** |