Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 430092

Summary:	Sirius is no more able to empty the GMF action bar
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Diagram	Assignee:	Maxime Porhel <maxime.porhel>
Status:	CLOSED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	pierre-charles.david
Version:	1.0.0M6	Keywords:	triaged
Target Milestone:	1.0.0M6
Hardware:	PC
OS:	Windows NT
Whiteboard:
Bug Depends on:	428322
Bug Blocks:

Description Maxime Porhel

2014-03-11 07:33:35 EDT

During the verification of Bug 428322 on a Luna M6 target platform, we discovered that the GMF actions are not removed from the main toolbar any more. 

This should be done in org.eclipse.sirius.diagram.part.SiriusDiagramActionBarContributor.init(IActionBars). 

The action bar is filled with the defaut GMF actions in super.init(), then we remove all unneeded toolbar items. But during the bar.updateActionBars(), the children of all menu manager items are added to the toolbar and then we have 70 items instead of the 27 expected items. The items are duplicated in the toolbar and our removal code is not sufficient any more.
Furthermore, the UI is updated on each contribution add, this slower a lot the diagram opening. 

The wrong population of the tabbar during UI refresh/updateActionsBars() looks like a platform bug. 

If we defer the action bars update, the update is done only once. Furthermore it occurs after the GMF actions removal. It makes the diagram opening faster (no  more update remove an action, update, ...).

Comment 1 Maxime Porhel

2014-03-11 07:38:49 EDT

See https://git.eclipse.org/r/23187 for correction proposal.

Comment 2 Maxime Porhel

2014-03-11 11:47:35 EDT

Reviewed by Pierre-Charles. 
See https://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=f348205a46b708e99854d6828a82014c7945edcf


Bug 430116 has been open to deal with the underlying issue with menu manager contributions to action bars.

Comment 3 Pierre-Charles David

2014-03-17 09:39:11 EDT

Verified on the final M6 release.

Comment 4 Pierre-Charles David

2014-03-17 10:07:04 EDT

Available in Sirius 1.0.0M6 (see https://wiki.eclipse.org/Sirius/1.0.0M6).