Bug 429954

Description Erlend Kristiansen 2014-03-09 07:37:08 EDT

Created attachment 240694 [details]
Project to reproduce bug

For the Extract Method refactoring: When extracting statements that references variables with a local type, the code breaks. For the method below, if one tries to extract all of the statements below the declaration of the local class, the user interface correctly informs that the "Selected block references a local type declared outside the selection.". But if extracting the code between the comments, the Extract Method refactoring performs without hesitation. This results in an extracted method with a parameter of the local type, that is no longer in its scope.

Before:
-------

void declaresLocalClass() {
    class LocalClass {
        void foo() {}
        void bar() {}
    }

    LocalClass inst = new LocalClass();
    // Extract method from here
    inst.foo();
    inst.bar();
    // to here
}


After:
------

void declaresLocalClass() {
    class LocalClass {
        void foo() {}
        void bar() {}
    }

    LocalClass inst = new LocalClass();
    // Extract method from here
    fooBar(inst);
    // to here
}

private void fooBar(LocalClass inst) {
    inst.foo();
    inst.bar();
}