Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 429601

Summary: Add basic menu item creation functions to dropdown module
Product: [ECD] Orion Reporter: Elijah El-Haddad <elijahe>
Component: ClientAssignee: Elijah El-Haddad <elijahe>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker
Version: 6.0   
Target Milestone: 6.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Elijah El-Haddad CLA 2014-03-04 16:13:38 EST 
The dropdown (web/orion/webui/dropdown.js) module currently doesn't provide any API which creates a basic menu item. Rather, callers such as commands.js and UserMenu.js are explicitly creating the items themselves. What's more, the code in dropdown.js actually depends on the items having a specific structure in order to work properly.

The dropdown menu item creation code should be moved inside the dropdown module and reused by callers. This will provide better encapsulation and allow the code to be reused.
Comment 1 Elijah El-Haddad CLA 2014-03-04 16:13:59 EST 
I have a fix for this. Can anyone with commit rights please assign the bug to me?
Comment 2 Elijah El-Haddad CLA 2014-03-04 16:15:19 EST 
Fix pushed to github: https://github.com/elijahe/orion.client/commit/898bc6dd2b7d9662a0868b53c56425016e56b18e