Bugzilla – Full Text Bug Listing
| Summary: | [patch] Adding missing entries for Solaris/X86 | ||
|---|---|---|---|
| Product: | [Eclipse Project] PDE | Reporter: | Thorsten Heit <theit> |
| Component: | Build | Assignee: | pde-build-inbox <pde-build-inbox> |
| Status: | RESOLVED WONTFIX | QA Contact: | |
| Severity: | enhancement | ||
| Priority: | P3 | CC: | curtis.windatt.public, david_williams |
| Version: | 4.4 | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Solaris-GTK | ||
| Whiteboard: | |||
| Bug Depends on: | |||
| Bug Blocks: | 429343, 442266 | ||
| Attachments: | |||
Is there a simple way for me to test this? Or could you create a junit test case? There are no active committers on PDE Build. (In reply to Curtis Windatt from comment #1) > Is there a simple way for me to test this? Or could you create a junit test > case? There are no active committers on PDE Build. I know this sounds like a stupid question, but what do you like to test? What do you mean by JUnit test case? A test case for what precisely? Can you point me to an example for this? (In reply to Thorsten Heit from comment #2) > I know this sounds like a stupid question, but what do you like to test? > What do you mean by JUnit test case? A test case for what precisely? Can you > point me to an example for this? PDE Build has a number of tests in the org.eclipse.pde.build.tests project in the PDE Build git repository. Those junit test cases are run as part of every Eclipse build. I am not familiar with the code your patch changes, so I cannot confirm that it works correctly and that it doesn't cause other problems (regressions). If you could give me steps that I could do on my machine that would demonstrate the problem and how it is fixed by your patch I could test that way. A more effective solution would be for you to add a new junit test to the existing tests that tested that the Solaris X86 entries were available. This has the added benefit where if someone breaks this functionality in the future, the tests will warn us. I can't point you a specific example test as I do not know what code your change would affect. Created attachment 246089 [details]
patch for eclipse.pde.build to add missing entries for Solaris x86/x86_64
Created attachment 246090 [details]
Shell script to apply the patch to eclipse.pde.build
Simple shell script to apply the patch to the eclipse.pde.build submodule.
As mentioned in bugs #429332 and #429335:
- The patch was made against the R4_4_maintenance branch.
- The script assumes that the patch resides in the same directory as the script itself.
- Apart from executing the script, there's nothing else to do.
This patch also applies to the master without any modifications. Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. Please reopen, if you plan to provide a fix. |
Created attachment 240409 [details] Missing entries for Solaris X86 / X86_64 In my attempts to build a native 64-bit version of Eclipse 4.4M5 (see bugs #429332 and #429335) I changed a few files in the eclipse.pde.build project; see attached patch. Basically I was looking for references to x86 / x86_64 and found out that there were a few files having entries for Solaris / Sparc, but not for Solaris X86/X86_64.