Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 429338

Summary: [CSS] Colors and Fonts defined in CSS can't be overridden
Product: [Eclipse Project] Platform Reporter: Paul Webster <pwebster>
Component: UIAssignee: Daniel Rolka <daniel.rolka>
Status: VERIFIED FIXED QA Contact: Daniel Rolka <daniel.rolka>
Severity: normal    
Priority: P3 CC: daniel_megert, Lars.Vogel
Version: 4.4   
Target Milestone: 4.4 M6   
Hardware: PC   
OS: Linux   
See Also: https://bugs.eclipse.org/bugs/show_bug.cgi?id=483359
Whiteboard:
Bug Depends on: 355946    
Bug Blocks:    

Description Paul Webster CLA 2014-02-28 12:36:48 EST 
If a color or font definition comes from CSS, it is in effect read-only as the user can't modify it from within the preference dialog.

We need to make these definitions work the same way as regular definitions.

PW
Comment 1 Daniel Rolka CLA 2014-02-28 17:59:49 EST 
I've pushed the initial version of the patch to Gerrit: https://git.eclipse.org/r/#/c/22706/

It seems to be working fine, but I have to test it deeper on Monday

thanks,
Daniel
Comment 2 Lars Vogel CLA 2014-03-03 09:53:03 EST 
Also if value has not been configured in the CSS, it cannot be changed. See Bug 429429
Comment 3 Lars Vogel CLA 2014-03-03 09:53:30 EST 
*** Bug 429429 has been marked as a duplicate of this bug. ***
Comment 5 Paul Webster CLA 2014-03-03 20:15:40 EST 
If this doesn't make it into the 20:00 EST build we'll have to revert it for M6

PW
Comment 6 Daniel Rolka CLA 2014-03-04 02:56:11 EST 
(In reply to Paul Webster from comment #5)
> If this doesn't make it into the 20:00 EST build we'll have to revert it for
> M6
> 
> PW

The build contains the patch so I'm going to verify it

Daniel
Comment 7 Daniel Rolka CLA 2014-03-04 05:29:10 EST 
Verified in the build: I20140303-2000

I've found one issue that will be handled with the separate bug - bug 429553

Daniel