Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 429153

Summary: Separate ide.css into two files.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: libing wang <libingw>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: antonm
Version: 5.0   
Target Milestone: 6.0 M1   
Hardware: PC   
OS: Windows 7   
Whiteboard:
Bug Depends on:    
Bug Blocks: 430555    

Description libing wang CLA 2014-02-26 09:25:53 EST 
One of the lessons I've learned from implementing the readonly file system widget is that the ide.css mixes things together.

I believe the initial approach of this css file was to put all the "global" styles, e.g. h1, h2, body font. But while things evolve, we added more stuff there.
At least we should separate the "global" part so that when a widget does not want to "share" the "global" style it can avoid it.

For example, currently if the readonly widget consumes ide.css directly it will hurt the hosting page.
What I had to do was to copy the majority of ide.css nad only customize 20%. So that 80% keeps stale if ide.css is updated.
Comment 1 libing wang CLA 2014-02-26 09:31:15 EST 
Anton, we will still keep ide.css but it will merely import two files:
documentLevel.css
otherLevel.css

I do not think it will affect the way we consume ide.css in other areas but please correct me if I'm wrong.
Comment 2 Anton McConville CLA 2014-02-26 11:00:45 EST 
Do what you think makes sense for this - there is likely too much in ide.css ...

... but I think otherLevel.css is not a great name - it could mean anything! :)

maybe otherLevel.css should remain ide.css, or base.css and documentLevel.css could be table.css or something - need to understand better what each file offers.