Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 429096

Summary:

Should be picking up buildpack options in manifest.yml

Product:

[ECD] Orion

Reporter:

Bogdan Gheorghe <gheorghe>

Component:

Deployment

Assignee:

Szymon Brandys <Szymon.Brandys>

Status:

RESOLVED FIXED

QA Contact:

Severity:

normal

Priority:

CC:

maciej.bendkowski, simon_kaegi, Szymon.Brandys

Version:

unspecified

Flags:

simon_kaegi: review+
maciej.bendkowski: review+
gheorghe: review+

Target Milestone:

5.0 RC3

Hardware:

OS:

Windows 7

Whiteboard:

Attachments:

Description	Flags
Potential patch	none
Improved patch for review	none

Description Bogdan Gheorghe

2014-02-25 16:48:58 EST

I'm pretty sure this used to work at one point, but in either case, we should be able to parse and forward any buildpack options set in the manifest file.

Comment 1 Bogdan Gheorghe

2014-02-25 16:49:34 EST

Created attachment 240306 [details]
Potential patch

Possible patch

Comment 2 Szymon Brandys

2014-02-26 05:04:12 EST

We switched to the new implementation and it was said that buildpacks support will be added later. I will review the patch and apply the fix asap.

Comment 3 Szymon Brandys

2014-02-26 07:02:57 EST

I modified the patch and it is waiting for Simon's review.

Comment 4 Szymon Brandys

2014-02-26 07:47:55 EST

Created attachment 240326 [details]
Improved patch for review

Comment 5 Maciej Bendkowski

2014-02-26 10:37:36 EST

(In reply to Szymon Brandys from comment #4)
> Created attachment 240326 [details]
> Improved patch for review

Indeed, we were supposed to add the buildpack support later.
The patch looks good to me.

Comment 6 Szymon Brandys

2014-02-26 11:21:46 EST

Fixed.