Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 429077

Summary:	Improve JS minification performance in build
Product:	[ECD] Orion	Reporter:	Mark Macdonald <mamacdon>
Component:	Releng	Assignee:	Mark Macdonald <mamacdon>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3
Version:	5.0
Target Milestone:	6.0 M1
Hardware:	PC
OS:	Windows 7
Whiteboard:

Description Mark Macdonald

2014-02-25 12:59:25 EST

The minification strategy used during the Orion builds (both Tycho and PDE) is too slow. It currently takes over 60 minutes to perform. 

We should investigate ways to make this faster.

Comment 1 Mark Macdonald

2014-03-07 11:30:39 EST

Fixed by this mass of commits

> 5c1ec97 Allow jsdoc generation to be skipped by setting 'skipJsdoc' property
> 7859c5d remove 'skipDirOptimize' from orion.build.js to avoid r.js problems
> 5e8350a [Bug 429077] ensure classpath entries are sorted
> 069877c [Bug 429077] going back to old classpath strategy
> 0bdbbce [Bug 429077] make build helper scripts work under Java 6 :(
> fb226e8 [Bug 429077] fix: wrong paths to Rhino/Closure jars in Hudson build
> dc061df [Bug 429077] fix incorrect classpath in orion.mini.xml
> 9f3d8ca Continuation of previous commit. Missed a spot
> 435edd1 [Bug 429077] fix PDE build breakage. r.js classpath needs to have js.jar before closure.jar (?!)
> 3caa695 [Bug 429077] rename Ant project to avoid conflicting with customTargets.xml
> 419d1fe [Bug 429077] refactor orion.jsdoc.xml to get bundles from orion.build.js
> b3c0a06 [Bug 429077] refactor Orion Node build to use extra info from orion.build.js
> 7241ebe [Bug 429077] Improve JS minification performance in build

The build time of orion-client has been reduced from ~68 mins to ~21 mins. The latter figure can be lowered even further in future by removing the workaround implemented in 7859c5d, which was needed to placate the PDE build.

Comment 2 Mark Macdonald

2014-03-07 12:04:22 EST

I should also mention these commits that went into the server repo:

> 11cc7d3 [Bug 429077] customTargets: reduce loglevel
> 40277c0 Keep optimizer-log.txt in each build's folder to avoid clobbering
> fd7774c Remove debugging - Revert "[Bug 429077] add -verbose to Ant runner for build debug"
> 26ebcef [Bug 429077] fix PDE build output needs to go in ${buildDirectory}/plugins/
> d51dfb3 [Bug 429077] fix PDE build minification
> 3c7395f [Bug 429077] add -verbose to Ant runner for build debug
> bd6aee6 [Bug 429077] refactor PDE build to use orion.mini.xml and orion.jsdoc.xml from client repo