Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428927

Summary: Search page does not render the result link with a line number properly.
Product: [ECD] Orion Reporter: libing wang <libingw>
Component: ClientAssignee: Silenio Quarti <Silenio_Quarti>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, libingw, Silenio_Quarti
Version: 5.0Flags: libingw: review+
Silenio_Quarti: review? (ken_walker)
Target Milestone: 5.0 RC3   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description libing wang CLA 2014-02-24 11:05:05 EST 
Open search page and do a search.
Click on a link with line number. It opens the editor without popping up the find bar. The link URL looks wrong:
https://orion.eclipse.org/edit/edit.html#/file/liwang-OrionContent/OrionClient/bundles/org.eclipse.orion.client.core/web/orion/fileClient.js,id=fileliwang-OrionContentOrionClientbundlesorg.eclipse.orion.client.coreweborionfileClient.js-17_itemLink
Comment 1 Silenio Quarti CLA 2014-02-24 11:08:25 EST 
I forgot to update a call to navigatorRenderer.createLink. It no longer takes the defaultEditor.

diff --git a/bundles/org.eclipse.orion.client.ui/web/orion/searchExplorer.js b/bundles/org.eclipse.orion.client.ui/web/orion/searchExplorer.js
index f53ef33..6278cc8 100644
--- a/bundles/org.eclipse.orion.client.ui/web/orion/searchExplorer.js
+++ b/bundles/org.eclipse.orion.client.ui/web/orion/searchExplorer.js
@@ -388,7 +388,7 @@
 		var params = helper ? mSearchUtils.generateFindURLBinding(helper.params, helper.inFileQuery, item.lineNumber, helper.params.replace, true) : null;
 		var name = null;
 		var link = navigatorRenderer.createLink(null, {Location: item.parent.location, Name: name}, this.explorer._commandService, this.explorer._contentTypeService,
-			this.explorer._openWithCommands, null /*defaultEditor*/, {id:this.getItemLinkId(item)}, params, {});
+			this.explorer._openWithCommands, {id:this.getItemLinkId(item)}, params, {});
         spanHolder.appendChild(link);

        mNavUtils.addNavGrid(this.explorer.getNavDict(), item, link);
Comment 2 libing wang CLA 2014-02-24 11:19:48 EST 
verified the patch.