Bugzilla – Full Text Bug Listing
| Summary: | Having a common debug window for all spies | ||
|---|---|---|---|
| Product: | [Eclipse Project] e4 | Reporter: | Olivier Prouvost <olivier.prouvost> |
| Component: | Tools | Assignee: | Olivier Prouvost <olivier.prouvost> |
| Status: | RESOLVED FIXED | QA Contact: | |
| Severity: | normal | ||
| Priority: | P3 | CC: | Lars.Vogel, wim.jongman |
| Version: | unspecified | ||
| Target Milestone: | --- | ||
| Hardware: | PC | ||
| OS: | Mac OS X | ||
| Whiteboard: | |||
|
Description
Olivier Prouvost
(In reply to Olivier Prouvost from comment #0) > Any comment ? +1 (In reply to Olivier Prouvost from comment #0) > Any comment ? I would prefer to have still the shortcuts for the individual spys. I think it is rare that I want to investigate on the application model, the event system and the CSS at the same time. But I would be nice to have the option to combine them. Why not define a custom perspective for all these tools and in the perspective have the option to "Detach perspective as new window". In general the option to "detach a perspective as new window" would be a cool IDE feature. (In reply to Lars Vogel from comment #2) > In general the option to "detach a perspective as new window" would be a > cool IDE feature. Silly me, Window -> New Window is exactly this. I think in this case a custom perspective would be the correct solution instead of a "special" solution with a shortcut opening a new window. Yes good idea... The perspective and all the key binding stuff would be provided by the common plugin using the extension point... To fix this bug I propose :
* to create a new plugin named : org.eclipse.e4.tools.spy
* a new extension point : org.eclipse.e4.tools.spy.spyPart
This extension point provides : name, part, shortcut, description and icon. The goal of this point is to have one code to manage the short cuts and to target a unique perspective or window.
I propose to name the window : E4 spies. It will also contain a toolbar to open the spies directly (without having to know the short cuts). It will be easier to discover them.
For instance, adding a new spy would be like this (no more processor to write) :
<plugin>
<extension
point="org.eclipse.e4.tools.spy.spyPart">
<spyPart
description="open the live model editor"
icon="icons/full/obj16/application_lightning.png"
name="Model Spy"
part="org.eclipse.e4.tools.emf.liveeditor.LivePartDelegator"
shortcut="M2+M3+F9">
</spyPart>
</extension>
</plugin>
All the processors in all spies will be removed and replaced by this extension and a common SpyProcessor.
Concerned spies would be : event spy, css spy, live model editor, context spy, and other future spies (memory ? , ...).
The plugin could also provide some common preferences (when it would be available).
Any idea around this ?
I think http://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=063d4a133182bee3fb1fb7a8086f13d2b32dd1c9 broke the build To test try to install the e4 core tools from http://download.vogella.com/luna/e4tools Do you have the build report ? What is broken exactly ? The hudson report was actually ok in gerrit... (In reply to Olivier Prouvost from comment #7) > Do you have the build report ? What is broken exactly ? The hudson report > was actually ok in gerrit... To test try to install the e4 core tools from http://download.vogella.com/luna/e4tools I think you now include a new plug-in into a feature but this feature is not build. (In reply to Olivier Prouvost from comment #7) > Do you have the build report ? What is broken exactly ? The hudson report > was actually ok in gerrit... For clarification: "You broke the build result", i.e., the build itself works but the result cannot get installed. You can validate that locally by excecuting "mvn clean verify" and trying to install the result from the local update site. Ok I got it ! It seems that the org.eclipse.e4.tools.spy must be added in all the existing features ! I check it locally and I will deliver it as soon as possible. Sorry about that. *** Bug 421452 has been marked as a duplicate of this bug. *** For information, this bug is fixed for : live model editor, event spy and context spy. it has been merged in master for a month. The css spy and css scratch pad are in progress but not still delivered. I pushed a patch for the css spy and scratch pad. https://git.eclipse.org/r/#/c/29220/ If everything is Ok I will remove definitively the dead code before closing this bug. Now 5 spies are in the E4 Spy window : model spy (live model editor), context spy, css spy, scratchpad for css and event spy. It will be easy to add other spies (memory spy ?, network spy, ... ?) using the extension point : org.eclipse.e4.tools.spy.spyPart Only the part and the shortcut must be provided and automatically the spy will be displayed in the E4 spies window. Of course, spies can always be put outside this window. Latest gerrit review : https://git.eclipse.org/r/#/c/29591/ Fixed with latest commit (but there are 5 additionals before) : https://git.eclipse.org/c/e4/org.eclipse.e4.tools.git/commit/?id=e9feaae3b7d8a5680ab771964c47b7e448f0a37d |