Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428791

Summary:	Readonly file widget: Need to capture additional errors to avoid showing "Loading..." forever.
Product:	[ECD] Orion	Reporter:	libing wang <libingw>
Component:	Client	Assignee:	libing wang <libingw>
Status:	RESOLVED FIXED	QA Contact:
Severity:	normal
Priority:	P3	CC:	Mike_Wilson, simon_kaegi
Version:	5.0
Target Milestone:	6.0 M2
Hardware:	PC
OS:	Windows 7
Whiteboard:
Bug Depends on:	428801, 432671, 432674, 432754
Bug Blocks:

Description libing wang

2014-02-21 14:18:55 EST

The widget injects a status service into the inputManager, which is the generic manager handing inputs. But there are still some cases we are missing for the error capturing:

1.We put a "loading..." message in the widget right after the widget is loaded by the caller. Then we start to load the matching file system plugins. The loading of the plugin basically takes all the time when the message is rendered. We should capture any errors during the plugin loading/handshake. If there are errors but the plugin registry does not throw it out we have to fix it inside the plugin resgistry code.

2.After the plugin is loaded, before calling inputManager, the widget makes a fetchChildren call to the plugin to intialize the content of branch selector. This part is done outside of the inputManager. We should also handle errors during this call. If the file system plugin does not capture and throw the errors, we need to fix it in the plugin code. For example, a typical error for the gitHub plugin is a 403 error. Currently the widget just shows "loading..." without telling user what happened.

Comment 1 libing wang

2014-04-02 15:34:59 EDT

Also we need a better UI:
1. We need to improve how the errors are rendered.
2. If error happens during the widget start up, we should translate errors to user readable.
3 If the error happens during the navigation, we need to keep the breadcrumb.

Comment 2 libing wang

2014-04-10 10:47:37 EDT

We also need to capture errors from plugin level and make them "Orion error" format so that the generic error handling can render them properly.

Comment 3 libing wang

2014-05-06 09:08:26 EDT

Need to fix the Gerrit plugin as well.

Comment 4 libing wang

2015-01-29 10:03:03 EST

this is already fixed on the gerrit plugin side.