Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428700

Summary: html content in .php files is not styled properly
Product: [ECD] Orion Reporter: Grant Gayed <grant_gayed>
Component: ClientAssignee: Grant Gayed <grant_gayed>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3    
Version: 5.0   
Target Milestone: 6.0 M1   
Hardware: PC   
OS: All   
Whiteboard:
Attachments:
Description Flags
patch to apply post-5.0
none
patch #2 none

Description Grant Gayed CLA 2014-02-20 19:47:45 EST
Created attachment 240178 [details]
patch to apply post-5.0

Patch is attached.

One remaining detail: the ending ?> or %> does not seem like it's getting styled.
Comment 1 Grant Gayed CLA 2014-02-21 10:41:48 EST
Created attachment 240205 [details]
patch #2

Attached an updated patch that addresses the comment 0 end-match styling problem.
Comment 2 Grant Gayed CLA 2014-02-25 14:43:51 EST
Additional patch to apply post-5.0, completely unrelated to this bug's issue:

diff --git a/bundles/org.eclipse.orion.client.editor/web/orion/editor/stylers/application_x-ejs/syntax.js b/bundles/org.eclipse.orion.client.editor/web/orion/editor/stylers/application_x-ejs/syntax.js
index 429c668..ab923fc 100644
--- a/bundles/org.eclipse.orion.client.editor/web/orion/editor/stylers/application_x-ejs/syntax.js
+++ b/bundles/org.eclipse.orion.client.editor/web/orion/editor/stylers/application_x-ejs/syntax.js
@@ -36,8 +36,6 @@
 			}
 		],
 		repository: {
-			/* override orion.xml#doctype (no-op) */
-			doctype: {},
 			/* override orion.xml#xmlDeclaration (no-op) */
 			xmlDeclaration: {}
 		}
Comment 3 Grant Gayed CLA 2014-03-03 15:47:41 EST
Fixed (along with some additional unrelated changes) > 20140303, commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=f6d7d22e5ba3024e50ddbdb8285a5b398eae424e .