Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428677

Summary:	implement syntax styling for .ejs files
Product:	[ECD] Orion	Reporter:	Grant Gayed <grant_gayed>
Component:	Client	Assignee:	Grant Gayed <grant_gayed>
Status:	RESOLVED FIXED	QA Contact:
Severity:	enhancement
Priority:	P3	CC:	john.arthorne, ken_walker, simon_kaegi
Version:	5.0	Flags:	simon_kaegi: review+ grant_gayed: review? (ken_walker)
Target Milestone:	5.0 RC3
Hardware:	PC
OS:	All
Whiteboard:

Description Grant Gayed

2014-02-20 12:48:04 EST

These are basically .html files that embed .js within <% %> and <%= %> markers.

Comment 1 Grant Gayed

2014-02-20 13:01:46 EST

Fixed > 20140220, commit: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=d359f0350dcf3e859810a20f805badb4d9b52e5a .

Comment 2 Grant Gayed

2014-02-20 13:05:19 EST

Also pushed to the R5.0RC2_maintenance branch.

Comment 3 John Arthorne

2014-02-21 17:00:31 EST

So this will only add syntax highlighting right? Other features like content assist and outline will still not work then. I was hoping for a way we could map the extension to an existing content type and get all the features in one go.

Comment 4 Grant Gayed

2014-02-24 10:20:16 EST

(In reply to John Arthorne from comment #3)
> So this will only add syntax highlighting right?

Correct.  To get the styling of embedded JS blocks right this type couldn't just be mapped to .html since it doesn't have this notion.  I guess our .html content assist could have been reused for files with this type, it just wouldn't be right as-is within embedded JS blocks.