Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428445

Summary: Markdown renderer fails when images are not viewable URLs
Product: [ECD] Orion Reporter: Simon Kaegi <simon_kaegi>
Component: ClientAssignee: Simon Kaegi <simon_kaegi>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: libingw
Version: 5.0   
Target Milestone: 5.0 RC2   
Hardware: PC   
OS: Windows 7   
Whiteboard:

Description Simon Kaegi CLA 2014-02-18 10:37:21 EST 
The markdown renderer is assuming file content urls are viewable directly which is not always the case. We instead need to readBlob and render them ourselves as a blob url.
Comment 1 Simon Kaegi CLA 2014-02-18 10:38:22 EST 
Libing has reviewed with me and I'm going to check-in and we will do more testing before closing this bug.
Comment 2 libing wang CLA 2014-02-18 12:39:54 EST 
I've built a readonly file widget and tested:
1. A folder with readme file with image files(relative URL) inside it, in Orion.
2. The readonly widget on a github repo (https://github.com/libingw/test1.git). The repo has a readme file with an image form a relative URL.

They all passed.
Comment 3 Simon Kaegi CLA 2014-02-27 00:40:09 EST 
Fixed.
Comment 4 Simon Kaegi CLA 2014-06-26 16:23:49 EDT 
.