Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428323

Summary:	[Workbench] Wrong action definition in ActionFactory
Product:	[Eclipse Project] Platform	Reporter:	Mauro Poggianella <m.poggianella>
Component:	UI	Assignee:	Tobias Baumann <tobbaumann>
Status:	VERIFIED FIXED	QA Contact:	Paul Webster <pwebster>
Severity:	normal
Priority:	P3	CC:	curtis.windatt.public, daniel_megert, tobbaumann
Version:	4.3.1	Keywords:	helpwanted
Target Milestone:	4.4 M6
Hardware:	All
OS:	All
Whiteboard:

Description Mauro Poggianella

2014-02-17 04:39:15 EST

In the org.eclipse.ui.actions.ActionFactory (line 632) the "LOCK_TOOL_BAR" Action is wrongly defined as "IWorkbenchCommandConstants.HELP_ABOUT", and should be "IWorkbenchCommandConstants.WINDOW_LOCK_TOOLBAR"

Comment 1 Curtis Windatt

2014-02-18 09:47:10 EST

This is definitely incorrect, but reading over the code, it looks like it should use getCommandId(), and not a direct constant.  The action factory is passed the literal "lockToolBar".  That could probably be replaced with the constant.  Though I'm not 100% sure as the constant is qualified "org.eclipse.ui.window.lockToolBar".

Moving to Platform UI for comment.

Comment 2 Paul Webster

2014-02-20 14:55:54 EST

Yes, it should be updated to new ActionFactory("lockToolBar", IWorkbenchCommandConstants.WINDOW_LOCK_TOOLBAR) and then the action creation should use getCommandId().

See https://wiki.eclipse.org/Platform_UI/How_to_Contribute

PW

Comment 3 Tobias Baumann

2014-03-02 13:27:51 EST

Thanks for the linked wiki page and following my first Gerrit patch set:
https://git.eclipse.org/r/#/c/22714/

Comment 4 Dani Megert

2014-03-05 16:12:34 EST

Submitted with http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=e6dac5182609b33ac3378c9cad00312302fa5364

Comment 5 Paul Webster

2014-03-06 15:39:59 EST

In 4.4.0.I20140305-2000

PW