Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428322

Summary:	The dynamic tabbar should be enabled for Luna
Product:	[Modeling] Sirius	Reporter:	Maxime Porhel <maxime.porhel>
Component:	Diagram	Assignee:	Maxime Porhel <maxime.porhel>
Status:	CLOSED FIXED	QA Contact:	Julien Dupont <julien.dupont>
Severity:	major
Priority:	P3	CC:	alex.lagarde, julien.dupont, pierre-charles.david
Version:	1.0.0M5	Keywords:	triaged
Target Milestone:	1.0.0M7
Hardware:	All
OS:	All
Whiteboard:
Bug Depends on:	410426
Bug Blocks:	430092

Description Maxime Porhel

2014-02-17 04:36:52 EST

Sirius has currently two tabbar configurations. 

The default configuration is a dynamic and contextual toolbar which use the menu service and accept contributions. Its items are provided with visibility conditons based on the current selection (diagram vs diagram element).

The second configuration has been created to workaround Bug 410426 on Eclipse 4.x, a reduced list of items is added to the tabbar wihtout visibility conditions or contributions. 

Now that Bug 410426 has been corrected for Luna, the dynamic tabbar should be enabled for Luna.

Comment 1 Maxime Porhel

2014-02-19 09:18:01 EST

See https://git.eclipse.org/r/22234 and https://git.eclipse.org/r/22239. 

We have to wait the next release of Luna to merge these review in master (our target platform points to http://download.eclipse.org/releases/luna, and http://git.eclipse.org/c/platform/eclipse.platform.ui.git/commit/?id=f27f2fad5a22a5a415e12dc26aaa474f3a7051cb is not part of a release yet).

Comment 2 Maxime Porhel

2014-03-06 03:49:06 EST

Fixed by http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=34da73f4221495bd4d06e2435c71d589e4d10895 and  http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/commit/?id=35ab4f28ff8585f9c557141424b15f72ce9345d0

Comment 3 Maxime Porhel

2014-03-10 07:39:07 EDT

Verified on Luna M6 win 32 (Build id: I20140306-1200)

The dynamic tabbar is enabled and well computed. 
We have just noticed a 'blink' effect during the enablement/visibleWhen computation of each item on selection change (DDiagram to DDiagramElement or DDiagramElement to DDiagram). 

We will investigate this in another bugzilla.

Comment 4 Pierre-Charles David

2014-03-17 10:04:35 EDT

Reopening as the tabbar in the final Luna M6 build is not dynamic. The feature worked at some point, several of us saw it working fine or release candidates for Sirius M6, but for some reason not yet identified it does not work anymore on the final M6.

Comment 5 Maxime Porhel

2014-03-17 10:47:07 EDT

Issue has been introduced during the following change: https://git.eclipse.org/r/#/c/22239/1..3/plugins/org.eclipse.sirius.diagram/src/org/eclipse/sirius/diagram/tools/internal/editor/tabbar/Tabbar.java

Then it has been corrected with the use of Range and reintroduced during correction of Bug 428976. This ticket has been marked as VERIFIED before the merge of https://git.eclipse.org/r/#/c/23233/ which should have re-trigger a verification.

See https://git.eclipse.org/r/#/c/23486/ for correction.

Comment 6 Maxime Porhel

2014-03-24 09:26:57 EDT

Fixed by commits 752c75e2139c16eed87b5b778e2e6f9118023ff0 and 438fc3f6f058b6be59b4eca9bbee0600f0c41490 (merge).

Comment 7 Pierre-Charles David

2014-05-12 03:46:03 EDT

Available in Sirius 1.0.0M7 (see https://wiki.eclipse.org/Sirius/1.0.0M7 & http://git.eclipse.org/c/sirius/org.eclipse.sirius.git/tag/?id=v1.0.0M7).