Bugzilla – Full Text Bug Listing
| Summary: | Navbar highlight colour should be consistent across the workspace sidebar and setting sidebar | ||||||
|---|---|---|---|---|---|---|---|
| Product: | [ECD] Orion | Reporter: | Gabriel Luong <gabriel.luong> | ||||
| Component: | Client | Assignee: | Gabriel Luong <gabriel.luong> | ||||
| Status: | RESOLVED FIXED | QA Contact: | |||||
| Severity: | normal | ||||||
| Priority: | P3 | CC: | antonm, ken_walker, mamacdon | ||||
| Version: | 5.0 | Flags: | gabriel.luong:
review?
(antonm) ken_walker: review+ mamacdon: review+ |
||||
| Target Milestone: | 5.0 RC3 | ||||||
| Hardware: | PC | ||||||
| OS: | Mac OS X | ||||||
| Whiteboard: | |||||||
| Attachments: |
|
||||||
https://github.com/gabrielluong/orion.client/commit/59092bafa549a8eebf8940ded362e15bbd1c358c?w=1 This patch changes the following: -Removes .navbar-item-selected from theme.css since it is dupe from settings.css and would override it otherwise. -Changes the default selection colour in ThemeSheetWriter.js. This selection colour applies to .checkRow and .navbar-item-selected which is the navbar row highlight colour. -Changes the background colour of .navbar-item-selected to be the same as the current workspace sidebar Verified that this fixes the issue. You will have to run localStorage.clear() in order to see the changes, however -- because one of the changes affects cached theme data, see bug 427696 for details. Since this is still RC3, I am fine with this as-is. But if this change were happening after a milestone, we would have to increment the theme version number in ThemeData.js. Just something to keep in mind in the future. |
Created attachment 240005 [details] Sidebars See attached. The highlight colour should be the same across the workspace sidebar and setting sidebar.