Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428283

Summary: Removed extra span outline around User dropdown menu
Product: [ECD] Orion Reporter: Gabriel Luong <gabriel.luong>
Component: ClientAssignee: Gabriel Luong <gabriel.luong>
Status: RESOLVED FIXED QA Contact:
Severity: normal    
Priority: P3 CC: ken_walker, mamacdon
Version: 5.0Flags: ken_walker: review+
mamacdon: review+
Target Milestone: 5.0 RC3   
Hardware: PC   
OS: Mac OS X   
Whiteboard:
Attachments:
Description Flags
Before none

Description Gabriel Luong CLA 2014-02-16 04:11:57 EST
Created attachment 239990 [details]
Before

STR:
1. When clicking on the user dropdown, you get an extra bulge coming out the left of the user icon.

Expected:
The outline should only be on the user icon.

See Attachments for a Before and After. In the Before, the span to remove is the middle one.
Comment 1 Gabriel Luong CLA 2014-02-16 04:21:54 EST
https://github.com/gabrielluong/orion.client/commit/4ce1bf8cd57d9fe848bbb452227909a4d5e405e2?w=1

This patch changes the following:
-Removes the extra span around the User dropdown
-Repositions the progress pane to the same extra position
-Removes dropdownArrowEmpty class from theme.css since it is used nowhere else
Comment 2 Mark Macdonald CLA 2014-02-20 15:07:29 EST
Seems fine.