Some Eclipse Foundation services are deprecated, or will be soon. Please ensure you've read this important communication.

Bug 428040

Summary: [eslint] Warn about unnecessary semicolon use
Product: [ECD] Orion Reporter: Michael Rennie <Michael_Rennie>
Component: JS ToolsAssignee: Michael Rennie <Michael_Rennie>
Status: RESOLVED FIXED QA Contact:
Severity: enhancement    
Priority: P3 CC: mamacdon, simon_kaegi
Version: 5.0Flags: mamacdon: review+
simon_kaegi: review+
Target Milestone: 5.0 RC2   
Hardware: All   
OS: All   
Whiteboard:
Attachments:
Description Flags
fix
none
update none

Description Michael Rennie CLA 2014-02-12 15:34:50 EST 
We should add a rule to warn about unnecessary semicolons
Comment 1 Michael Rennie CLA 2014-02-12 15:53:08 EST 
Created attachment 239881 [details]
fix

Adds support + prefs + tests for warning about unnecessary semicolons
Comment 2 Michael Rennie CLA 2014-02-12 15:53:34 EST 
Mark, give the patch a try
Comment 3 Michael Rennie CLA 2014-02-12 16:15:11 EST 
Created attachment 239882 [details]
update

Seems the last patch was missing the code changes to the plugin, which provides the UI for the prefs.
Comment 4 Simon Kaegi CLA 2014-02-12 16:26:04 EST 
Fine with this as new feature
Comment 5 Mark Macdonald CLA 2014-02-12 23:13:47 EST 
I'm having trouble applying patches right now but I looked at the code and it seems fine.

My only comment would be to name the rule "no-extra-semi" so we keep the same rule naming scheme as eslint master. I still vainly hope for a day when we can leverage the eslint rules rather than maintain our own.
Comment 6 Michael Rennie CLA 2014-02-13 11:48:07 EST 
Pushed fix to: http://git.eclipse.org/c/orion/org.eclipse.orion.client.git/commit/?id=c996a4cbec553bf3092342e4a12dcc54bd1eefa8

Renamed the rule to no-extra-semi